Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use custom LLVM builds #2921

Closed
syrusakbary opened this issue Jun 1, 2022 · 0 comments · Fixed by #2949
Closed

Use custom LLVM builds #2921

syrusakbary opened this issue Jun 1, 2022 · 0 comments · Fixed by #2949
Assignees
@silwol
Labels
🎉 enhancement New feature!
Milestone
v3.0

Comments

@syrusakbary
Copy link
Member

Right now, the default LLVM builds require the library libtinfo.so.5 which is not always available (for example, in musl).

We should go back to using https://github.com/wasmerio/llvm-custom-builds in our codebase to remove this dependency.

This issue is a follow-up from #2822
@syrusakbary syrusakbary added the 🎉 enhancement New feature! label Jun 1, 2022
@syrusakbary syrusakbary added this to the v3.0 milestone Jun 1, 2022
@syrusakbary syrusakbary mentioned this issue Jun 1, 2022
Closed
@epilys epilys linked a pull request Jun 6, 2022 that will close this issue
CI: use custom LLVM builds #2932
Closed
@epilys epilys mentioned this issue Jun 6, 2022
Closed
@syrusakbary syrusakbary assigned silwol and unassigned epilys Jun 9, 2022
silwol added a commit that referenced this issue Jun 14, 2022
@silwol
Switch back to using custom LLVM builds
978b3f7 
Closes: #2921
This was referenced Jun 14, 2022
Merged
Merged
silwol added a commit that referenced this issue Jun 14, 2022
@silwol
Switch back to using custom LLVM builds on CI
8ddddd7 
Closes: #2921
silwol added a commit that referenced this issue Jun 14, 2022
@silwol
Switch back to using custom LLVM builds on CI
f1b9ebd 
Closes: #2921
silwol added a commit that referenced this issue Jun 15, 2022
@silwol
Switch back to using custom LLVM builds on CI
867ecaf 
Closes: #2921
@silwol silwol mentioned this issue Jun 15, 2022
Closed
silwol added a commit that referenced this issue Jun 16, 2022
@silwol
Switch back to using custom LLVM builds on CI
ed2deb9 
Closes: #2921
silwol added a commit that referenced this issue Jun 20, 2022
@silwol
Switch back to using custom LLVM builds on CI
8f813db 
Closes: #2921
bors bot added a commit that referenced this issue Jun 21, 2022
@bors @silwol
Merge #2949
1667998 
2949: Switch back to using custom LLVM builds on CI r=epilys a=silwol

Closes: #2921

# Description
Switch back to using the custom LLVM builds from [wasmerio/llvm-custom-builds](https://github.com/wasmerio/llvm-custom-builds).

This will remove the dependency of binaries to `libtinfo5`, verified that in a VM.

# Review

- [x] Add a short description of the change to the CHANGELOG.md file

Co-authored-by: Wolfgang Silbermayr <[email protected]>
@bors bors bot closed this as completed in afa2476 Jun 21, 2022
epilys pushed a commit that referenced this issue Jul 20, 2022
@silwol @epilys
Switch back to using custom LLVM builds on CI
4bd7e92 
Closes: #2921
ptitSeb pushed a commit that referenced this issue Oct 20, 2022
@silwol @ptitSeb
Switch back to using custom LLVM builds on CI
4a0fff0 
Closes: #2921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@silwol silwol

Labels
🎉 enhancement New feature!
Projects
None yet
Milestone
v3.0
3 participants
@syrusakbary @silwol @epilys