Use Undefined instruction with payload to carry over TrapInformation on Singlepass #2836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…without using an vector or hashmap on Singlepass
syrusakbary
reviewed
Apr 4, 2022
syrusakbary
reviewed
Apr 4, 2022
|
Tests seem to be failing |
Amanieu
reviewed
Apr 7, 2022
… Singlepass (to fix Trap opcode tracking)
|
Based on the comment from Amanieu, we can merge manually (tests are already passing for everything) |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 11, 2022
2836: Use Undefined instruction with payload to carry over TrapInformation on Singlepass r=ptitSeb a=ptitSeb # Description Use Undefined instruction with payload to carry over TrapInformation on without using an vector or hashmap on Singlepass. This allow for slightly more compact binary and slightly faster trap decoding on runtime. Co-authored-by: ptitSeb <[email protected]>
|
Timed out. |
|
bors retry |
|
Already running a review |
|
Those TimeOut seems to be more and more frequent now. There is an issue with the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use Undefined instruction with payload to carry over TrapInformation on without using an vector or hashmap on Singlepass.
This allow for slightly more compact binary and slightly faster trap decoding on runtime.