Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Rename wasmer-engine-native to wasmer-engine-dylib #2356

Merged
merged 4 commits into from
May 28, 2021
Merged

feat: Rename wasmer-engine-native to wasmer-engine-dylib #2356

merged 4 commits into from
May 28, 2021

Conversation

Hywan
Copy link
Contributor

@Hywan Hywan commented May 27, 2021 •
edited
Loading

This (small) patch renames the wasmer-engine-native crate into
wasmer-engine-dylib. We believe the new name conveys
better the intent of the engine.

I will update the CHANGELOG later.

@Hywan Hywan self-assigned this May 27, 2021
@Hywan Hywan added 🎉 enhancement New feature! 📚 documentation Do you like to read? 🧪 tests I love tests labels May 27, 2021
@Hywan Hywan force-pushed the feat-rename-native-engine branch from b32c401 to 93cba79 Compare May 27, 2021 14:11
@Hywan
Copy link
Contributor Author

Hywan commented May 27, 2021

bors try

bors bot added a commit that referenced this pull request May 27, 2021
@bors
Try #2356:
1b8bb28
@bors
Copy link
Contributor

bors bot commented May 27, 2021

try

Build failed:

@Hywan
Copy link
Contributor Author

Hywan commented May 27, 2021

bors try

bors bot added a commit that referenced this pull request May 27, 2021
@bors
Try #2356:
e5376a3
@bors
Copy link
Contributor

bors bot commented May 27, 2021

try

Build failed:

@Hywan
Copy link
Contributor Author

Hywan commented May 27, 2021

The error comes from the compiler_test proc macro that transforms the engine name (SharedObject) into the feature name (sharedobject), but in this case, it's wrong (it must be shared-object). I'm modifying the code accordingly.

@Hywan
Copy link
Contributor Author

Hywan commented May 27, 2021

bors try

bors bot added a commit that referenced this pull request May 27, 2021
@bors
Try #2356:
5c477f3
@bors
Copy link
Contributor

bors bot commented May 27, 2021

try

Build failed:

@syrusakbary
Copy link
Member

As talked offline, let's go with wasmer-engine-dylib. Apologizes for the misdirection here!

@Hywan
Copy link
Contributor Author

Hywan commented May 28, 2021

bors try

bors bot added a commit that referenced this pull request May 28, 2021
@bors
Try #2356:
10a6a21
@Hywan Hywan changed the title feat: Rename wasmer-engine-native to wasmer-engine-shared-object feat: Rename wasmer-engine-native to wasmer-engine-dylib May 28, 2021
@bors
Copy link
Contributor

bors bot commented May 28, 2021

try

Build failed:

@Hywan
Copy link
Contributor Author

Hywan commented May 28, 2021

bors try

bors bot added a commit that referenced this pull request May 28, 2021
@bors
Try #2356:
3c542ad
@bors
Copy link
Contributor

bors bot commented May 28, 2021

try

Build failed:

@Hywan
Copy link
Contributor Author

Hywan commented May 28, 2021

bors try

bors bot added a commit that referenced this pull request May 28, 2021
@bors
Try #2356:
a4c89a5
@bors
Copy link
Contributor

bors bot commented May 28, 2021

try

Build failed:

@Hywan
Copy link
Contributor Author

Hywan commented May 28, 2021

bors try

bors bot added a commit that referenced this pull request May 28, 2021
@bors
Try #2356:
a4f83ad
@Hywan Hywan marked this pull request as ready for review May 28, 2021 10:45
@bors
Copy link
Contributor

bors bot commented May 28, 2021

try

Build failed:

@Hywan
Copy link
Contributor Author

Hywan commented May 28, 2021

bors try

bors bot added a commit that referenced this pull request May 28, 2021
@bors
Try #2356:
5e22862
@bors
Copy link
Contributor

bors bot commented May 28, 2021

try

Build succeeded:

@Hywan Hywan force-pushed the feat-rename-native-engine branch from 6937764 to 3d66a2e Compare May 28, 2021 12:13
@Hywan
Copy link
Contributor Author

Hywan commented May 28, 2021

bors r+

@Hywan Hywan mentioned this pull request May 28, 2021
Closed
@bors
Copy link
Contributor

bors bot commented May 28, 2021

Build succeeded:

@bors bors bot merged commit 77ae2b3 into wasmerio:master May 28, 2021
@Hywan Hywan mentioned this pull request May 31, 2021
Merged
bors bot added a commit that referenced this pull request May 31, 2021
@bors @Hywan
Merge #2364
7d09f94 
2364: feat: Rename `wasmer-engine-object-file` to `wasmer-engine-staticlib`. r=Hywan a=Hywan

# Description

This PR renames the `wasmer-engine-object-file` crate into `wasmer-engine-staticlib`. We believe it conveys a better meaning of what it does. This PR is similar to its siblings, #2340 and #2356.

Co-authored-by: Ivan Enderlin <[email protected]>
@Hywan Hywan mentioned this pull request Jun 2, 2021
Closed
5 tasks
@ailisp ailisp mentioned this pull request Jun 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jubianchi jubianchi jubianchi approved these changes

@MarkMcCaskey MarkMcCaskey Awaiting requested review from MarkMcCaskey

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees

@Hywan Hywan

Labels
📚 documentation Do you like to read? 🎉 enhancement New feature! 🧪 tests I love tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Hywan @syrusakbary @jubianchi @audioXD