-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Rename wasmer-engine-jit
to wasmer-engine-universal
#2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
added
🎉 enhancement
New feature!
🧪 tests
I love tests
📚 documentation
Do you like to read?
labels
May 25, 2021
bors try |
Hywan
commented
May 25, 2021
This (small) patch renames the `wasmer-engine-jit` crate into `wasmer-engine-universal`.
Hywan
force-pushed
the
feat-rename-jit-engine
branch
from
May 25, 2021 14:12
7f935fd
to
e5a784a
Compare
bors try |
tryBuild failed: |
syrusakbary
approved these changes
May 25, 2021
bors try |
tryBuild failed: |
jubianchi
reviewed
May 25, 2021
bors try |
Co-authored-by: Julien BIANCHI <[email protected]>
Co-authored-by: Julien BIANCHI <[email protected]>
Co-authored-by: Julien BIANCHI <[email protected]>
… feat-rename-jit-engine
tryBuild failed: |
It didn't failed, I've cancelled it myself. bors r+ |
bors bot
added a commit
that referenced
this pull request
May 31, 2021
2364: feat: Rename `wasmer-engine-object-file` to `wasmer-engine-staticlib`. r=Hywan a=Hywan # Description This PR renames the `wasmer-engine-object-file` crate into `wasmer-engine-staticlib`. We believe it conveys a better meaning of what it does. This PR is similar to its siblings, #2340 and #2356. Co-authored-by: Ivan Enderlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (small) patch renames the
wasmer-engine-jit
crate intowasmer-engine-universal
. We believe the new name conveysbetter the intent of the engine.
I will update the
CHANGELOG
later.