Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reference-types tests #2283

Closed
wants to merge 1 commit into from
Closed

Added reference-types tests #2283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ fn main() -> anyhow::Result<()> {
"tests/wast/spec/proposals/multi-value",
wast_processor,
)?;
test_directory_module(
spectests,
"tests/wast/spec/proposals/reference-types",
wast_processor,
)?;
Comment on lines +47 to +51
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey May 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because reference types are fully stabilized, we don't need this and it's likely that the tests in there are out of date and failing in wasmparser or the semantics are out of date. #2268 is fully testing reference types. (edit and master is also entirely or mostly testing them... there are no additional failures related to ref types in #2268)

test_directory_module(spectests, "tests/wast/spec/proposals/simd", wast_processor)?;
// test_directory_module(spectests, "tests/wast/spec/proposals/bulk-memory-operations", wast_processor)?;
Ok(())
Expand Down
4 changes: 4 additions & 0 deletions tests/compilers/wast.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,15 @@ pub fn run_wast(wast_path: &str, compiler: &str) -> anyhow::Result<()> {
);
let try_nan_canonicalization = wast_path.contains("nan-canonicalization");
let mut features = Features::default();
let is_referencetypes = wast_path.contains("reference-types");
let is_bulkmemory = wast_path.contains("bulk-memory");
let is_simd = wast_path.contains("simd");
if is_bulkmemory {
features.bulk_memory(true);
}
if is_referencetypes {
features.reference_types(true);
}
Comment on lines +50 to +58
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference types are enabled by default in tests now I believe, I don't think these changes do anything

if is_simd {
features.simd(true);
}
Expand Down