Added reference-types tests #2283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkMcCaskey
reviewed
May 4, 2021
Comment on lines
+50
to
+58
| let is_referencetypes = wast_path.contains("reference-types"); | ||
| let is_bulkmemory = wast_path.contains("bulk-memory"); | ||
| let is_simd = wast_path.contains("simd"); | ||
| if is_bulkmemory { | ||
| features.bulk_memory(true); | ||
| } | ||
| if is_referencetypes { | ||
| features.reference_types(true); | ||
| } |
There was a problem hiding this comment.
Reference types are enabled by default in tests now I believe, I don't think these changes do anything
Comment on lines
+47
to
+51
| test_directory_module( | ||
| spectests, | ||
| "tests/wast/spec/proposals/reference-types", | ||
| wast_processor, | ||
| )?; |
There was a problem hiding this comment.
Because reference types are fully stabilized, we don't need this and it's likely that the tests in there are out of date and failing in wasmparser or the semantics are out of date. #2268 is fully testing reference types. (edit and master is also entirely or mostly testing them... there are no additional failures related to ref types in #2268)
|
Closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I tried to enable reference types but spectests are failing.
cc @MarkMcCaskey
Review