Add test that shows local memory/table lifetime bug #2131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
that referenced
this pull request
May 3, 2021
2281: Refactor vm r=syrusakbary a=syrusakbary <!-- Prior to submitting a PR, review the CONTRIBUTING.md document for recommendations on how to test: https://github.com/wasmerio/wasmer/blob/master/CONTRIBUTING.md#pull-requests --> # Description This PR simplifies the VM code. and improves it's resiliency: * [x] Removed unnecessary Exported structs * [x] Reuse same VM data when available. Fixing #2131 * [x] Removed unnecessary Function Definition in the API * [ ] Fixes the NativeEngine by automatically deallocating the libraries when the module is no longer used <!-- Provide details regarding the change including motivation, links to related issues, and the context of the PR. --> # Review - [ ] Add a short description of the change to the CHANGELOG.md file Co-authored-by: Syrus <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>
|
@syrusakbary Is it closed by #2281? |
Hywan
added
🧪 tests
|
We need to check if this issue still exists on |
syrusakbary
added
the
🕵️ needs investigation
|
No longer relevant since objects are now owned by the Context/Store and the actual |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that we expect these things to work while the store/engine is alive but critical data is stored in the
Instanceitself and theInstancedoes not live as long as the engine/store.Review