-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new Context API for Wasmer 3.0 #2892
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 1, 2022
This was referenced Jun 1, 2022
epilys
force-pushed
the
context_api
branch
6 times, most recently
from
June 17, 2022 16:43
66e1315
to
aca9e93
Compare
syrusakbary
reviewed
Jun 17, 2022
syrusakbary
reviewed
Jun 17, 2022
It was never fully implemented and we're moving to a different way of tracking ExternRef lifetimes.
Co-authored-by: ptitSeb <[email protected]>
Co-authored-by: Manos Pitsidianakis <[email protected]>
Co-authored-by: ptitSeb <[email protected]> Co-authored-by: Manos Pitsidianakis <[email protected]>
…idden (for wit-bindgen)
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR reworks the way Wasmer manages objects used by instances, specifically:
Instance
,Memory
,Table
,Function
,Global
andExternRef
. Previously these were tracked using reference counting, but this cannot work fully because Wasm code can manipulate references to functions (and by implication the instance that function is from) using tables.The new approach uses a
Context
type which owns all of the objects listed above: objects are only freed when theContext
is dropped. TheInstance
,Memory
,Table
,Function
,Global
andExternRef
types are now simply wrappers around an integer which indexes a vector in theContext
. As a result, any function on those "handle" types now need to take a&Context
or&mut Context
as a parameter to access the actual data in the context. This also vastly simplifies Wasmer's thread-safety story: since all mutating operations require a&mut Context
, no synchronization or internal locks are needed.Additionally, the way host functions are represented is also changed. The
WasmerEnv
trait is removed since it was unergonomic and hard to use correctly. Instead, the state for host functions is stored directly as theT
inContext<T>
. This state is initialized when the context is created, and can be accessed through thedata
anddata_mut
methods onContext<T>
. All host functions receive aContextMut<'_, T>
as their first argument, which gives them access to the host state of the context. This is much better than the old approach since it provides mutable access without locks and allows all host functions to share the same state.This design is heavily inspired by this RFC from Wasmtime.
TODO
c-api
to use the new APIFixes #2893
Fixes #2873
Fixes #2866
Fixes #1840
Fixes #1734
Fixes #1632
Fixes #1522
Fixes #1630
Fixes #2838
Fixes #2856
Fixes #2544
Fixes #2816