fix(c-api) Avoid more than one call to the function environment finalizer #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
added a commit
to Hywan/wasmer
that referenced
this pull request
Feb 1, 2021
Hywan
changed the title
Hywan
force-pushed
the
fix-c-api-wasmerenv-func-finalizer
branch
from
9bdcf81 to
1357740
Compare
…izer. A function environment `WrapperEnv` can be cloned. In case the original and the cloned environments are being dropped, the `self.finalizer` function —if any— is called twice. That's a bug. It must be called only once. This patch updates the code to apply the finalizer only once by taking it —if any— the first time it's called.
Hywan
force-pushed
the
fix-c-api-wasmerenv-func-finalizer
branch
from
1357740 to
b954429
Compare
MarkMcCaskey
approved these changes
Feb 1, 2021
|
bors r+ |
jubianchi
approved these changes
Feb 1, 2021
jubianchi
added a commit
to wasmerio/wasmer-php
that referenced
this pull request
Feb 1, 2021
jubianchi
added a commit
to wasmerio/wasmer-php
that referenced
this pull request
Feb 1, 2021
jubianchi
added a commit
to wasmerio/wasmer-php
that referenced
this pull request
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A function environment
WrapperEnvcan be cloned. In case theoriginal and the cloned environments are being dropped, the
self.finalizerfunction —if any— is called twice. That's a bug. Itmust be called only once.
This patch updates the code to apply the finalizer only once by taking
it —if any— the first time it's called.
This bug has been raised by @jubianchi when working with PHP and the Zend Engine GC.
Review