-
Notifications
You must be signed in to change notification settings - Fork 824
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
2084: fix(c-api) Avoid more than one call to the function environment finalizer r=Hywan a=Hywan # Description A function environment `WrapperEnv` can be cloned. In case the original and the cloned environments are being dropped, the `self.finalizer` function —if any— is called twice. That's a bug. It must be called only once. This patch updates the code to apply the finalizer only once by taking it —if any— the first time it's called. This bug has been raised by @jubianchi when working with PHP and the Zend Engine GC. # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Ivan Enderlin <[email protected]>
- Loading branch information
Showing
2 changed files
with
13 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters