Fix memory leak in wat2wasm function #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkMcCaskey
force-pushed
the
fix/capi-wat2wasm-mem-leak
branch
from
42af38d to
deec77d
Compare
nlewycky
reviewed
Dec 1, 2020
lib/c-api/src/wasm_c_api/wat.rs
Outdated
Comment on lines
16
to
19
| Err(err) => { | ||
| crate::error::update_last_error(err); | ||
| return; | ||
| } |
There was a problem hiding this comment.
How does the caller know whether wat2wasm succeeded? Is there a way to initialize a wasm_byte_vec_t to "clear" which the user can then test for? Or does it always check for errors with a separate "did the last thing fail" call after every call to wat2wasm?
There was a problem hiding this comment.
That's a fair point, in this case I'd assume the user would initialize to null prior and check for that, but perhaps it makes more sense for us to zero the fields for them on failure
There was a problem hiding this comment.
You can also use the return value if you like.
nlewycky
reviewed
Dec 1, 2020
Co-authored-by: nlewycky <[email protected]>
Co-authored-by: nlewycky <[email protected]>
nlewycky
approved these changes
Dec 1, 2020
nlewycky
reviewed
Dec 1, 2020
lib/c-api/wasmer_wasm.h
Outdated
| @@ -237,8 +237,8 @@ int wasmer_last_error_message(char *buffer, int length); | |||
| * Parses in-memory bytes as either the WAT format, or a binary Wasm | |||
| * module. This is wasmer-specific. | |||
| * | |||
| * In case of failure, `wat2wasm` returns `NULL`. | |||
| * In case of failure, `wat2wasm` fills the `out->data = NULL` and `out->size = 0`. | |||
There was a problem hiding this comment.
Grammar here is a little off, but meh.
|
bors r+ |
1 task
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #1853 ;
Found with @nlewycky
Review