fix(c-api) Memory leak around wasm_$name_vec_delete
#1853
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch does several things: 1. It applies our Rust patterns for C API by replacing the raw pointer by `Option<Box<T>>`, 2. It allows `wasm_$name_vec_delete` to handle null pointer, 3. Because it takes ownership of the `wasm_$name_vec_t`, the pointer is correctly dropped (which fix the memory leak).
Hywan
commented
Dec 1, 2020
| let _ = Vec::from_raw_parts(subject.data, subject.size, subject.size); | ||
| } | ||
|
|
||
| ::std::ptr::drop_in_place(Box::into_raw(subject)); |
There was a problem hiding this comment.
Without that, everything compiles nicely but we have a free error when executing a C program.
1 task
bors bot
added a commit
that referenced
this pull request
Dec 1, 2020
1855: Fix memory leak in wat2wasm function r=MarkMcCaskey a=MarkMcCaskey Alternative to #1853 ; Found with @nlewycky # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <[email protected]> Co-authored-by: Mark McCaskey <[email protected]>
|
Closing this one as #1855 got merged and is an alternative to this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP
Review