Update wasi-tests to test multiple versions of WASI
#1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change also cleans up the `wasi-test` generation a bit. It's actually still really, really messy, but at least now it's split up into easier to understand chunks. There's still a lot of low-hanging fruit in terms of improving the readibilty and maintainability of the code.
syrusakbary
reviewed
Mar 13, 2020
syrusakbary
reviewed
Mar 13, 2020
| mod readlink; | ||
| mod wasi_sees_virtual_root; | ||
| mod writing; | ||
| mod snapshot1_close_preopen_fd; |
There was a problem hiding this comment.
Perhaps having them in different dirs might be good? (not sure)
There was a problem hiding this comment.
I agree, I think that's a good change. It's a bit non-trivial to update it though as it will require updating some of the structure of the code and the way the ignore list works -- I think that'd be a good follow up issue, but I can prioritize it now if you want!
Co-Authored-By: Syrus Akbary <[email protected]>
syrusakbary
approved these changes
Mar 16, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 16, 2020
1300: Update `wasi-tests` to test multiple versions of WASI r=MarkMcCaskey a=MarkMcCaskey This change also cleans up the `wasi-test` generation a bit. It's actually still really, really messy, but at least now it's split up into easier to understand chunks. There's still a lot of low-hanging fruit in terms of improving the readability and maintainability of the code. Improves test coverage over what's on master. Things in `ignores.txt` weren't being tested on master either; we should do a follow up to remove them from there (will require finding a good solution for raw WASI calls) # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <[email protected]> Co-authored-by: Mark McCaskey <[email protected]>
|
bors r+ |
|
bors r- |
|
bors r+ |
|
Already running a review |
Build failed
|
|
bors r+ |
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also cleans up the
wasi-testgeneration a bit. It'sactually still really, really messy, but at least now it's split up
into easier to understand chunks.
There's still a lot of low-hanging fruit in terms of improving the
readability and maintainability of the code.
Improves test coverage over what's on master. Things in
ignores.txtweren't being tested on master either; we should do a follow up to remove them from there (will require finding a good solution for raw WASI calls)Review