Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve structure of wasitest tests #1309

Closed
MarkMcCaskey opened this issue Mar 16, 2020 · 2 comments
Closed

Improve structure of wasitest tests #1309

MarkMcCaskey opened this issue Mar 16, 2020 · 2 comments
Labels
🎉 enhancement New feature!

Comments

@MarkMcCaskey
Copy link
Contributor

Wasitests were updated in #1300. Currently things are lexically scoped (for example: snapshot1_<test-name>), ideally these should use the module system (like snapshot1::<test_name>).

As part of this change, we'll need to handle this in the ignores file too. And the overall structure can be changed so that we generate in chunks based on the WASI version.
@MarkMcCaskey MarkMcCaskey added the 🎉 enhancement New feature! label Mar 16, 2020
@syrusakbary
Copy link
Member

Our WASI tests are greatly improved in the refactor. Thus, we can close this issue once it lands

@syrusakbary
Copy link
Member

Closing issue since the refactor has now landed in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎉 enhancement New feature!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@syrusakbary @MarkMcCaskey