Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Size of a pointer is always POINTER_BYTE_SIZE. #18

Merged
merged 3 commits into from
Jun 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions crates/loupe/src/memory_usage/cell.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,12 @@ use std::mem;

impl<T> MemoryUsage for UnsafeCell<T> {
fn size_of_val(&self, tracker: &mut dyn MemoryUsageTracker) -> usize {
if tracker.track(self.get() as *const ()) {
POINTER_BYTE_SIZE
} else {
0
}
mem::size_of_val(self)
+ if tracker.track(self.get() as *const ()) {
POINTER_BYTE_SIZE
} else {
0
}
}
}

Expand Down Expand Up @@ -38,7 +39,7 @@ mod test_cell_types {
#[test]
fn test_unsafecell() {
let cell = UnsafeCell::<i8>::new(1);
assert_size_of_val_eq!(cell, POINTER_BYTE_SIZE);
assert_size_of_val_eq!(cell, mem::size_of_val(&cell) + POINTER_BYTE_SIZE);
}

#[test]
Expand Down
39 changes: 8 additions & 31 deletions crates/loupe/src/memory_usage/ptr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,62 +5,39 @@ use std::mem;
use std::ptr::NonNull;

impl<T> MemoryUsage for *const T {
fn size_of_val(&self, tracker: &mut dyn MemoryUsageTracker) -> usize {
if tracker.track(*self as *const ()) {
POINTER_BYTE_SIZE
} else {
0
}
fn size_of_val(&self, _tracker: &mut dyn MemoryUsageTracker) -> usize {
POINTER_BYTE_SIZE
}
}

impl<T> MemoryUsage for *mut T {
fn size_of_val(&self, tracker: &mut dyn MemoryUsageTracker) -> usize {
if tracker.track(*self as *const _ as *const ()) {
POINTER_BYTE_SIZE
} else {
0
}
fn size_of_val(&self, _tracker: &mut dyn MemoryUsageTracker) -> usize {
POINTER_BYTE_SIZE
}
}

impl<T> MemoryUsage for NonNull<T> {
fn size_of_val(&self, tracker: &mut dyn MemoryUsageTracker) -> usize {
if tracker.track(self.as_ptr() as *const _ as *const ()) {
POINTER_BYTE_SIZE
} else {
0
}
fn size_of_val(&self, _tracker: &mut dyn MemoryUsageTracker) -> usize {
POINTER_BYTE_SIZE
}
}

#[cfg(test)]
mod test_pointer_types {
use super::*;
use std::collections::BTreeSet;

#[test]
fn test_pointer() {
let mut tracker = BTreeSet::new();

let x = 1i8;
let ptr = &x as *const _;
assert_size_of_val_eq!(ptr, POINTER_BYTE_SIZE, &mut tracker);

let ptr = &x as *const _;
assert_size_of_val_eq!(ptr, 0, &mut tracker);
assert_size_of_val_eq!(ptr, POINTER_BYTE_SIZE);
}

#[test]
fn test_mutable_pointer() {
let mut tracker = BTreeSet::new();

let mut x = 1i8;
let ptr = &mut x as *mut _;
assert_size_of_val_eq!(ptr, POINTER_BYTE_SIZE, &mut tracker);

let ptr = &mut x as *mut _;
assert_size_of_val_eq!(ptr, 0, &mut tracker);
assert_size_of_val_eq!(ptr, POINTER_BYTE_SIZE);
}

#[test]
Expand Down
6 changes: 6 additions & 0 deletions crates/loupe/tests/derive.rs
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,12 @@ fn test_tuple() {
struct Tuple(i32, i32);

assert_size_of_val_eq!(8, Tuple(1, 2));

#[derive(MemoryUsage)]
#[repr(transparent)]
struct Ptr(*const usize);

assert_size_of_val_eq!(8, Ptr(&1));
}

#[test]
Expand Down