fix: Size of a pointer is always POINTER_BYTE_SIZE.
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The size of a pointer must always be `POINTER_BYTE_SIZE`. The tracker must not come up in this level, it must be used in upper types.
The size of an `UnsafeCell` is the size of itself, in addition to the size of its content (viewed as a pointer) if not visited already.
Hywan
added a commit
to Hywan/wasmer
that referenced
this pull request
Jun 17, 2021
It includes this patch wasmerio/loupe#18 that fixes this bug CosmWasm/cosmwasm#959.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch does 2 things:
POINTER_BYTE_SIZE. The trackermust not come up in this level, it must be used in upper types.
UnsafeCellis the size of itself, in addition to thesize of its content (viewed as a pointer) if not visited already.
It addresses CosmWasm/cosmwasm#959.