fix(scaler): always publish delete notification #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksmtownsend
requested review from
autodidaddict,
thomastaylor312 and
connorsmith256
as code owners
thomastaylor312
approved these changes
Jan 12, 2024
|
Good to go once tests pass |
Just a heads up that some of the test fixes went into #233, really just updating to v0.81 and the "new" heartbeat/inventory format |
Signed-off-by: Brooks Townsend <[email protected]>
brooksmtownsend
force-pushed
the
fix/ensure-notify-delete
branch
from
60e9d1f
to
c3ac611
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR fixes a possible issue where, in the case where a single wadm instance doesn't find scalers for a particular manifest name, it won't notify the other instances to delete those scalers as well. After this fix, anytime we request to remove scalers (which is only when a manifest is undeployed) we will send the
DeleteScalersnotification to each instance.Related Issues
Release Information
Can be a patch release cherry picked for 0.9.2, or just pushed into 0.10.0.
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification