feat(*)!: prevent querying inventory for new heartbeat #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksmtownsend
commented
Jan 10, 2024
brooksmtownsend
force-pushed
the
feat/handle-new-heartbeat-format
branch
2 times, most recently
from
3b7620c
to
84fc985
Compare
Signed-off-by: Brooks Townsend <[email protected]> rip out last #191 artifact Signed-off-by: Brooks Townsend <[email protected]> cleanup Signed-off-by: Brooks Townsend <[email protected]> pr cleanup Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]>
brooksmtownsend
force-pushed
the
feat/handle-new-heartbeat-format
branch
from
3b1b04a
to
0630987
Compare
brooksmtownsend
requested review from
autodidaddict,
thomastaylor312 and
connorsmith256
as code owners
|
Tests pass, but I'm still working through one or two things with the heartbeat handling. |
connorsmith256
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR sets up the HostHeartbeat struct that we use in Wadm to be able to deserialize either the wasmCloud v0.81.0 version of the heartbeat or the v0.82.0 version of the heartbeat. Once v0.82.0 is released, we can remove the code branches handling the v81 heartbeat and take advantage of the additional information there to prevent querying host inventory on each heartbeat.
Related Issues
Handles wasmCloud/wasmCloud#1160
Fixes #191
Release Information
v0.10.0
Consumer Impact
Backwards compatible with older versions of the host.
Testing
Unit Test(s)
Some unit tests were modified to rip out old inventory format code. Additionally, tests were modified to support wash 0.25.0 and some new control interface command formats.
Acceptance or Integration
All tests were updated to wash 0.25.0, wasmcloud 0.81.0, and NATS 2.10.7
Manual Verification