Merged
Conversation
walbourn
reviewed
Mar 15, 2024
walbourn
reviewed
Mar 15, 2024
Fix for Release alt configurations
dg0yt
commented
Mar 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You may pick parts as you like. I didn't test more than
vcpkg installfor x64-linux and x64-linux-dynamic.debug/includeis never written.tools, even on linux. I don't like it, but it is a fact.<requested-name>_FOUND. I dropped explicit setting ofdirectx-dxc_FOUND.DIRECTX_DXC_TOOLas a cache variable. Doesn't hurt, and user might override it to a host path for cross builds.DIRECTX_DXC_TOOLneither matches the former explicitdirectx-dxc_FOUNDnor the general<requested-name>_FOUND(unless the user asked forfind_package(DIRECTX_DXC)).libz.so.1. With portzlibinstalled, this will resolve to that port's binary instead of a system binary. To avoid subtle effects from installation order, I suggest to make zlib an explicit dependency at least for dynamic triplets.