Skip to content

[directx-dxc] Fix port bug with TARGET_RUNTIME_DLLS#37401

Merged
BillyONeal merged 22 commits intomicrosoft:masterfrom
walbourn:directxdxcfix
Mar 20, 2024
Merged

[directx-dxc] Fix port bug with TARGET_RUNTIME_DLLS#37401
BillyONeal merged 22 commits intomicrosoft:masterfrom
walbourn:directxdxcfix

Conversation

@walbourn
Copy link
Member

@walbourn walbourn commented Mar 12, 2024 •
edited
Loading

While working with CMake 3.21 or later's TARGET_RUNTIME_DLLS I realized the extra space in the .in file was breaking the cmake -E copy command.

Also includes some cleanup for the port as well as respecting VCPKG_BUILD_TYPE=release.

@LilyWangLL LilyWangLL self-assigned this Mar 13, 2024
@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label Mar 13, 2024
LilyWangLL
LilyWangLL previously approved these changes Mar 13, 2024
View reviewed changes
@LilyWangLL LilyWangLL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 13, 2024
dg0yt
dg0yt reviewed Mar 13, 2024
View reviewed changes
@walbourn walbourn marked this pull request as draft March 13, 2024 04:58
@LilyWangLL LilyWangLL removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 13, 2024
@walbourn walbourn changed the title [directx-dxc] Fix port bug with extra space [directx-dxc] Fix port bug with TARGET_RUNTIME_DLLS Mar 13, 2024
@walbourn walbourn marked this pull request as ready for review March 13, 2024 17:31
@walbourn walbourn requested review from LilyWangLL and dg0yt March 14, 2024 22:35
dg0yt
dg0yt reviewed Mar 15, 2024
View reviewed changes
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There a few glitches also in the original version. Maybe I can make a PR to your fork.

@dg0yt
Copy link
Contributor

dg0yt commented Mar 15, 2024

walbourn#1

walbourn added 2 commits March 15, 2024 10:10
@walbourn
Update directx-dxc-config.cmake.in
918c5fb 
Fix for Release alt configurations
@walbourn
Merge pull request #1 from dg0yt/directx-dxc
6c3da1f 
Fixes for port
@walbourn walbourn requested a review from dg0yt March 15, 2024 17:20
@walbourn walbourn mentioned this pull request Mar 15, 2024
Closed
@dg0yt
Copy link
Contributor

dg0yt commented Mar 16, 2024

The x64-windows-static-md is related to walbourn#1 (comment). Maybe you want to revert walbourn@2b4d191. Or/and we teach vcpkg_check_linkage to deal with this type of libraries.

@LilyWangLL
Copy link
Contributor

LilyWangLL commented Mar 20, 2024

Usage passed on x64-windows.

@LilyWangLL LilyWangLL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 20, 2024
@BillyONeal BillyONeal merged commit c039e36 into microsoft:master Mar 20, 2024
@BillyONeal
Copy link
Member

BillyONeal commented Mar 20, 2024

Thanks!

@walbourn walbourn deleted the directxdxcfix branch May 4, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dg0yt dg0yt Awaiting requested review from dg0yt

1 more reviewer

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LilyWangLL LilyWangLL

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@walbourn @dg0yt @LilyWangLL @BillyONeal