Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fs-router): allow _components & _hooks in the pages folder #1222

Merged
merged 5 commits into from
Feb 11, 2025

Conversation

tylersayshi
Copy link
Member

@tylersayshi tylersayshi commented Feb 10, 2025

ignores any files inside _components and _hooks folders inside src/pages.

Previously, these would be considered to be pages but they will now be ignored. This allows easier co-location of components with their pages.

resolves #1220

Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
waku ⬜️ Ignored (Inspect) Visit Preview Feb 11, 2025 8:21am

Copy link

codesandbox-ci bot commented Feb 10, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi dai-shi mentioned this pull request Feb 11, 2025
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
We need docs for fs-router...

@dai-shi dai-shi merged commit e93d14b into wakujs:main Feb 11, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(fs-router): allow components in the pages folder
2 participants