feat(fs-router): allow _components & _hooks in the pages folder (#1222)

ignores any files inside `_components` and `_hooks` folders inside
`src/pages`.

Previously, these would be considered to be pages but they will now be
ignored. This allows easier co-location of components with their pages.

resolves #1220

---------

Co-authored-by: Tyler <[email protected]>

Author: tylersayshi

e2e/fixtures/fs-router/src/components/Counter.tsx e2e/fixtures/fs-router/src/pages/_components/Counter.tsx

@@ -1,4 +1,4 @@
-import { Counter } from '../components/Counter.js';
+import { Counter } from './_components/Counter.js';
 
 const Bar = () => (
   <div>

e2e/fixtures/fs-router/src/pages/bar.tsx

@@ -1,4 +1,4 @@
-import { Counter } from '../../components/Counter.js';
+import { Counter } from '../_components/Counter.js';
 
 const Foo = () => (
   <div>

e2e/fixtures/fs-router/src/pages/foo/index.tsx

@@ -76,5 +76,10 @@ for (const mode of ['DEV', 'PRD'] as const) {
       expect(res.status).toBe(200);
       expect(await res.text()).toBe('POST Hello from API! from the test!');
     });
+
+    test('_components', async ({ page }) => {
+      await page.goto(`http://localhost:${port}/_components/Counter`);
+      await expect(page.getByText('404 Not Found')).toBeVisible();
+    });
   });
 }

e2e/fs-router.spec.ts

@@ -68,6 +68,9 @@ export function unstable_fsRouter(
           .replace(/\.\w+$/, '')
           .split('/')
           .filter(Boolean);
+        if (pathItems.includes('_components') || pathItems.includes('_hooks')) {
+          continue;
+        }
         const path =
           '/' +
           (['_layout', 'index', '_root'].includes(pathItems.at(-1)!)