Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Poetry version to readme #158

Merged
merged 5 commits into from
Oct 20, 2022

Conversation

lb-
Copy link
Member

@lb- lb- commented Oct 19, 2022

This is a single commit built built on a different PR #157

  • First time using Poetry for me and spent about 30 minutes on various errors to find that Poetry 1.2.2 is required due to some backwards incompatibility issues.
  • I have built on Adopt Prettier (code formatting) #157 with a small change to the Readme that just clarifies the version to use.

Some notes / links

python-poetry/poetry#4983

poetry install
...setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
  warnings.warn(

  RuntimeError

  The Poetry configuration is invalid:
    - Additional properties are not allowed ('group' was unexpected)
  

  at ~/.poetry/lib/poetry/_vendor/py3.10/poetry/core/factory.py:43 in create_poetry
       39│             message = ""
       40│             for error in check_result["errors"]:
       41│                 message += "  - {}\n".format(error)
       42│ 
    →  43│             raise RuntimeError("The Poetry configuration is invalid:\n" + message)
       44│ 
       45│         # Load package
       46│         name = local_config["name"]
       47│         version = local_config["version"]
make: *** [backend] Error 1

@lb- lb- force-pushed the feature/add-poetry-version-to-readme branch from d58eb25 to 8a43ac3 Compare October 19, 2022 20:55
Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that LB! Agree this is an important point as our configuration will definitely fail with v1.1 and earlier.

@thibaudcolas thibaudcolas added this to the Before launch milestone Oct 20, 2022
@thibaudcolas thibaudcolas merged commit 9ca0e14 into wagtail:main Oct 20, 2022
@lb-
Copy link
Member Author

lb- commented Oct 20, 2022

Curious @thibaudcolas - why are we using Poetry for this Wagtail project when we do not use it for any others (maybe we do, but I have not used it in the Wagtail repos I have worked on).

@lb- lb- deleted the feature/add-poetry-version-to-readme branch October 20, 2022 10:05
@thibaudcolas
Copy link
Member

@lb- two reasons:

@lb-
Copy link
Member Author

lb- commented Oct 21, 2022

Ahh I see thanks Thibaud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants