Adopt Prettier (code formatting) #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lb-
commented
Oct 19, 2022
lb-
commented
- Resolves Adopt Prettier (JS/SCS/MD formatting) #114
- Relates to Front-end tooling upgrades #151
lb-
force-pushed
the
feaature/114-adopt-prettier
branch
from
3127dc1
to
c58ec89
Compare
thibaudcolas
approved these changes
Oct 20, 2022
There was a problem hiding this comment.
Looking great! One thing I think we could consider revisit, let me know what you think @lb-.
| "start": "webpack --mode=development --watch --progress", | ||
| "build": "webpack --mode=production", | ||
| "format": "prettier --write .", | ||
| "lint:format": "prettier --check .", |
There was a problem hiding this comment.
Note I think this won’t process dotfiles (.gitpod.yml). If we wanted this we’d need a more complex pattern like the one we use in Wagtail.
There was a problem hiding this comment.
ahh ok - I always wondered why you did that.
Have raised #162 for an improvement.
| - Python >= 3.9 | ||
| - Poetry | ||
| - Git | ||
| - Node 16.\* |
There was a problem hiding this comment.
yeah true, I did not even look at that - not sure why Prettier changed this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.