fit: Skip array fields on pre read messages #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wader
reviewed
Feb 12, 2024
| func readUint(d *decode.D, fDef mappers.LocalFieldDef, valMap valueMap) { | ||
| expectedSize := expectedSizeMap[fDef.Type] | ||
| if fDef.Size != expectedSize { | ||
| d.SeekRel(int64(fDef.Size) * 8) // skip over array types since they cannot be referenced by subfields |
There was a problem hiding this comment.
How come this seek and the a seek in fitDecodeDataMessage does not cause "gaps", some other field cover that bit range?
There was a problem hiding this comment.
This seek and the one on line 360 are just to keep the pos in sync since we only care about uint fields on the first pass. On line 363 we seek back to before the pre-read and read all the data with d.Field-methods.
|
+54 -44 😢 thought it would save lines 😬 |
You win some, you lose some =) At least it's less repeating code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also used your type->size idea for the expected sizes which simplified the switch statements alot.