Conversation
lsaether
suggested changes
May 5, 2020
laboon
requested changes
May 25, 2020
Co-authored-by: Bill Laboon <laboon@users.noreply.github.com>
Co-authored-by: Bill Laboon <laboon@users.noreply.github.com>
Co-authored-by: Bill Laboon <laboon@users.noreply.github.com>
Co-authored-by: Bill Laboon <laboon@users.noreply.github.com>
amaury1093
reviewed
May 25, 2020
Tbaut
reviewed
May 25, 2020
Co-authored-by: Bill Laboon <laboon@users.noreply.github.com>
Co-authored-by: Bill Laboon <laboon@users.noreply.github.com>
Co-authored-by: Bill Laboon <laboon@users.noreply.github.com>
Co-authored-by: Bill Laboon <laboon@users.noreply.github.com>
Co-authored-by: Bill Laboon <laboon@users.noreply.github.com>
Contributor
|
Waiting on new screenshots from @ansonla3 |
added 2 commits
May 26, 2020 18:27
Swader
approved these changes
May 26, 2020
Contributor
Swader
left a comment
Swader
left a comment
There was a problem hiding this comment.
Apart from some typos on screenshots (submitting separately to Apps) everything seems fine
joepetrowski
approved these changes
May 26, 2020
laboon
requested changes
May 26, 2020
| prior sales. You will need to have access to this account in order to make a signature. | ||
|
|
||
| [MyCrypto][] is a versatile wallet that supports a variety of storage methods for your Ethereum | ||
| account. Go to their downloads page and ensure that you download the latest version for your |
Contributor
There was a problem hiding this comment.
Should we include a link to their downloads page here? Or say that it was linked previously?
Collaborator
There was a problem hiding this comment.
It is linked in the MyCrypto right there. But could just move that to "downloads page" in the text.
Contributor
There was a problem hiding this comment.
Yeah, it was linked in the previous sentence, but to me this just looks awkward saying "go to their downloads page" without a link or reference.
My preference would be to move the link to here.
|
|
||
| The Polkadot JS [Claims app][] helps you sign a message from MyCrypto. MyCrypto is a good choice in | ||
| case you have stored the key to the Ethereum account holding your DOT indicator tokens on a hardware | ||
| device like a Ledger Nano S or a Trezor. It also supports raw private keys, mnemonics, and Parity |
Contributor
There was a problem hiding this comment.
MyCrypto with Trezor can't sign, apparently. Not sure why.
Contributor
There was a problem hiding this comment.
I wonder if this is a new change?
Co-authored-by: Bill Laboon <laboon@users.noreply.github.com>
Co-authored-by: Bill Laboon <laboon@users.noreply.github.com>
Co-authored-by: Bill Laboon <laboon@users.noreply.github.com>
Co-authored-by: Bill Laboon <laboon@users.noreply.github.com>
Co-authored-by: Bill Laboon <laboon@users.noreply.github.com>
Co-authored-by: Bill Laboon <laboon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #396
closes #452
Images still need to be updated.