Staking miner deposit and reward section#3954
Merged
Conversation
Contributor
Author
|
cc: @kianenigma |
alfarok
reviewed
Oct 19, 2022
Contributor
alfarok
left a comment
alfarok
left a comment
There was a problem hiding this comment.
Hey @emresurmeli, everything looks good to me! I just have 2 minor formatting related suggestions. If my suggestions look okay to you, I think you are good to merge pending any additional feedback from @DrW3RK.
DrW3RK
requested changes
Oct 19, 2022
Member
There was a problem hiding this comment.
Thanks @alfarok Your suggestions can be committed to the PR
A few minor issues to address. The newly added content is very resourceful to understand the reward mechanics. Thanks! @emresurmeli
kianenigma
reviewed
Oct 24, 2022
kianenigma
reviewed
Oct 24, 2022
kianenigma
reviewed
Oct 24, 2022
kianenigma
reviewed
Oct 24, 2022
kianenigma
reviewed
Oct 24, 2022
kianenigma
reviewed
Oct 24, 2022
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
Has a few small mistakes, looks good otherwise.
emresurmeli
force-pushed
the
staking-miner-reward
branch
from
fddf513 to
cf9ffa5
Compare
emresurmeli
force-pushed
the
staking-miner-reward
branch
from
cf9ffa5 to
17f73af
Compare
…reward mechnics section
…d example deposit based on weight calculation
emresurmeli
requested review from
DrW3RK,
alfarok and
kianenigma
and removed request for
kianenigma
Member
|
I guess it is better to hardcode this value and modify it after the issue #3986 is resolved. I will be pushing the changes shortly
|
DrW3RK
reviewed
Oct 26, 2022
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
DrW3RK
approved these changes
Oct 28, 2022
alfarok
added a commit
that referenced
this pull request
Nov 2, 2022
* Avalanche comparison (#3784) * Add avalanche comparison page and add it to the sidebar * Add Avalanche to the main page intro * Add Avalanche comparison info * Add into, model and architecture sections * Add governance * Add references * Add consensus section * Add staking and message passing * Add upgradibility and conslusion sections * Update docs/learn/learn-comparison-avalanche.md Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Update docs/learn/learn-comparison-avalanche.md Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Update docs/learn/learn-comparison-avalanche.md Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Update docs/learn/learn-comparison-avalanche.md Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Update docs/learn/learn-comparison-avalanche.md Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Update docs/learn/learn-comparison-avalanche.md Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Update docs/learn/learn-comparison-avalanche.md Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Update docs/learn/learn-comparison-avalanche.md Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Update docs/learn/learn-comparison-avalanche.md Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Update docs/learn/learn-comparison-avalanche.md Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Update docs/learn/learn-comparison-avalanche.md Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Update docs/learn/learn-comparison-avalanche.md Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Rename file for conformity * Resources added, remove to do * Improve upon architecture and p/x chain sections * Add comment to add infographics, and add a simple image visualizing ava network architecture * add new section talking about founders and company * Add ava network image * Expand on network info * Expand on consensus and add image * Add consensus image * Expand on metrics that can be changed via governance * Add staking info and remove sharding section as it doesn't exist in Avalanche * Grammarly * Update docs/learn/learn-comparisons-avalanche.md Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Update docs/learn/learn-comparisons-avalanche.md Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Update docs/learn/learn-comparisons-avalanche.md Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Update docs/learn/learn-comparisons-avalanche.md Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Update docs/learn/learn-comparisons-avalanche.md Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Add BABE and GRANDPA links * Add XCM and XCMP links * Add attributes to image sources * Add Polkadot staking mechanics to the staking section * Rephrase conclusion * Update docs/learn/learn-comparisons-avalanche.md Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Update docs/learn/learn-comparisons-avalanche.md Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Update docs/learn/learn-comparisons-avalanche.md Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Clarify Subnet section * Clarify subnets, primary network and fix flow * final touches * Add Image sources to display Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * minor fixes - avalanche page (#3963) * minor fixes - avalanche page * Remove physical realm section As no comparison is provided for Polkadot * Add Staking Page links to Nominator guide (#3965) * Update Kusama Guide link on Nominator page * Add note about Warp syncing (#3940) * Add note about Warp syncing * Reposition the note * Update docs/maintain/maintain-guides-how-to-validate-polkadot.md Co-authored-by: Bastian Köcher <git@kchr.de> * Update maintain-guides-how-to-validate-polkadot.md * Add description for warp sync * add info about default sync settings * minor fix * Add correct info * rephrase Co-authored-by: Bastian Köcher <git@kchr.de> * Update learn-polkadotjs.md (#3968) minor UI issue * Update open source stack (#3964) * Update open source stack Updating the security part, adding clockchain, adding Rust pdotc * add badges Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Adding Primis to the open source stack (#3966) * Adding Primis to the open source stack Adding Primis to the open source stack * Add badge Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Address regular audit of broken external wiki links (#3969) * start fixing links * address broken link in build-node-management * remove broken link as entire site is offline * restore parachain tutorials * don't pretty format build-open-source and fix or remove broken links * remove support article that is no longer available * update research link * remove another dot leap ref * remove radium blocks as site no longer exists * restore links to Phragmen Voting and Justified Representation paper * Update docs/general/kusama/kusama-community.md Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * update radium block from io to com ext Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * auction schedule update (#3976) Co-authored-by: Polkadot-Kusama Bot <polkadot-kusama-automation-bot@users.noreply.github.com> * Update status badges (#3977) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update build-open-source.md (#3975) * NPoS - Remove outdated info (#3974) - the calls to staking pallet are no longer filtered - add link to Staking Miner * Small change in Phragmen algorithm explainer (#3971) If I understood the explanation correctly, I believe point (1) of the algorithm is wrong. Voters cast their vote to candidates, and not candidates to candidates. If this is wrong, please dismiss this PR. * Update build-open-source.md (#3972) Add Supersig Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Bump @polkadot/api from 9.5.2 to 9.6.1 (#3982) Bumps [@polkadot/api](https://github.com/polkadot-js/api/tree/HEAD/packages/api) from 9.5.2 to 9.6.1. - [Release notes](https://github.com/polkadot-js/api/releases) - [Changelog](https://github.com/polkadot-js/api/blob/master/CHANGELOG.md) - [Commits](https://github.com/polkadot-js/api/commits/v9.6.1/packages/api) --- updated-dependencies: - dependency-name: "@polkadot/api" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump immer from 9.0.15 to 9.0.16 (#3981) Bumps [immer](https://github.com/immerjs/immer) from 9.0.15 to 9.0.16. - [Release notes](https://github.com/immerjs/immer/releases) - [Commits](immerjs/immer@v9.0.15...v9.0.16) --- updated-dependencies: - dependency-name: immer dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump katex from 0.16.2 to 0.16.3 (#3980) Bumps [katex](https://github.com/KaTeX/KaTeX) from 0.16.2 to 0.16.3. - [Release notes](https://github.com/KaTeX/KaTeX/releases) - [Changelog](https://github.com/KaTeX/KaTeX/blob/main/CHANGELOG.md) - [Commits](KaTeX/KaTeX@v0.16.2...v0.16.3) --- updated-dependencies: - dependency-name: katex dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Adding Polkadot Basic Notifications (#3983) * Adding Polkadot Basic Notifications Adding Polkadot Basic Notifications to the tech stack * Add status badge Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Improve Staking Miner intro (#3973) * Improve Staking Miner intro - Add links to NPoS and Offchain workers - Run grammarly - fix typos * Update docs/learn/learn-staking-miner.md Co-authored-by: Emre Surmeli <s.emre.s.8@gmail.com> Co-authored-by: Emre Surmeli <s.emre.s.8@gmail.com> * Bump jest from 29.2.1 to 29.2.2 (#3984) Bumps [jest](https://github.com/facebook/jest/tree/HEAD/packages/jest) from 29.2.1 to 29.2.2. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/jest/commits/v29.2.2/packages/jest) --- updated-dependencies: - dependency-name: jest dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump jest-environment-jsdom from 29.2.1 to 29.2.2 (#3985) Bumps [jest-environment-jsdom](https://github.com/facebook/jest/tree/HEAD/packages/jest-environment-jsdom) from 29.2.1 to 29.2.2. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/jest/commits/v29.2.2/packages/jest-environment-jsdom) --- updated-dependencies: - dependency-name: jest-environment-jsdom dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix Formatting - Treasury page (#3987) * Update build-open-source.md (#3988) * Minor fix - NPoS doc * Staking miner deposit and reward section (#3954) * Syntax fixes * Use deposit instead of bond in wording, and add a draft section for deposit and reward mechanics * Finalize deposit and reward section draft * Add signed phase parameter configuration definitions to resources * Replace with permalinks * Move Deposit and reward mechanics to bottom, makes more sense there * Flush out grammar and explanation of signed phase before deposit and reward mechnics section * Refine the deposit and reward mechanics section * Fix consts.electionProviderMultiPhase.signedDepositByte output and add example deposit based on weight calculation * hardcode values as temp fix * Update docs/learn/learn-staking-miner.md Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Update status badges (#3993) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * auction schedule update (#3992) Co-authored-by: Polkadot-Kusama Bot <polkadot-kusama-automation-bot@users.noreply.github.com> * Bump @docusaurus/preset-classic from 2.1.0 to 2.2.0 (#3994) Bumps [@docusaurus/preset-classic](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus-preset-classic) from 2.1.0 to 2.2.0. - [Release notes](https://github.com/facebook/docusaurus/releases) - [Changelog](https://github.com/facebook/docusaurus/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/docusaurus/commits/v2.2.0/packages/docusaurus-preset-classic) --- updated-dependencies: - dependency-name: "@docusaurus/preset-classic" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @docusaurus/plugin-client-redirects from 2.1.0 to 2.2.0 (#3995) Bumps [@docusaurus/plugin-client-redirects](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus-plugin-client-redirects) from 2.1.0 to 2.2.0. - [Release notes](https://github.com/facebook/docusaurus/releases) - [Changelog](https://github.com/facebook/docusaurus/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/docusaurus/commits/v2.2.0/packages/docusaurus-plugin-client-redirects) --- updated-dependencies: - dependency-name: "@docusaurus/plugin-client-redirects" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @docusaurus/module-type-aliases from 2.1.0 to 2.2.0 (#3996) Bumps [@docusaurus/module-type-aliases](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus-module-type-aliases) from 2.1.0 to 2.2.0. - [Release notes](https://github.com/facebook/docusaurus/releases) - [Changelog](https://github.com/facebook/docusaurus/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/docusaurus/commits/v2.2.0/packages/docusaurus-module-type-aliases) --- updated-dependencies: - dependency-name: "@docusaurus/module-type-aliases" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @polkadot/api from 9.6.1 to 9.6.2 (#3998) Bumps [@polkadot/api](https://github.com/polkadot-js/api/tree/HEAD/packages/api) from 9.6.1 to 9.6.2. - [Release notes](https://github.com/polkadot-js/api/releases) - [Changelog](https://github.com/polkadot-js/api/blob/master/CHANGELOG.md) - [Commits](https://github.com/polkadot-js/api/commits/v9.6.2/packages/api) --- updated-dependencies: - dependency-name: "@polkadot/api" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update build-open-source.md (#4001) * Update build-open-source.md Add Signac * Update badge Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Add Parami, update litentry (#4003) * Add Parami, update litentry Add Parami to the open source stack, update litentry * Update badge Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> * Add projects to "Easy Runtime Development" (#4004) * Add projects to "Easy Runtime Development" Add projects to "Easy Runtime Development" * Update badge Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Emre Surmeli <s.emre.s.8@gmail.com> Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Anwesh <anweshknayak@gmail.com> Co-authored-by: David Hawig <davidhawig@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Polkadot-Kusama Bot <polkadot-kusama-automation-bot@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Diogo <112647953+dsm-w3f@users.noreply.github.com> Co-authored-by: Santi Balaguer <santiago.balaguer@gmail.com> Co-authored-by: S E R A Y A <takahser@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sebastian Müller <sebastian@web3.foundation>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a deposit and reward mechanics section, and use "deposit" instead of "bond" when talking about the locked-up DOT required by the staking miners. Targeting issue #3915