Skip to content

Update reference hardware#3564

Merged
DrW3RK merged 7 commits into
w3f:masterfrom
bakhtin:update-system-reqs
Aug 9, 2022
Merged

Update reference hardware#3564
DrW3RK merged 7 commits into
w3f:masterfrom
bakhtin:update-system-reqs

Conversation

@ggwpez
Copy link
Copy Markdown
Contributor

@ggwpez ggwpez commented Jul 22, 2022

Fixup for #3550

TODOs for moved to #3653:

  • Mention Docker (and probably why not to use it)
  • Give some price estimations
  • Mention benchmark machine command

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez force-pushed the update-system-reqs branch from 0800e1a to 4240865 Compare July 22, 2022 17:04
@DrW3RK DrW3RK added the A0 - Do Not Merge Pull request should not yet be merged. label Jul 23, 2022
bakhtin and others added 3 commits August 1, 2022 15:34
Signed-off-by: bakhtin <a@bakhtin.net>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Comment thread docs/maintain/maintain-guides-how-to-validate-polkadot.md Outdated
Comment on lines +306 to +308
rustup install nightly-2022-05-18
rustup target add wasm32-unknown-unknown --toolchain nightly-2022-05-18
cargo +nightly-2022-05-18 build --release
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we always need to specify a specific rust nightly date? they cannot just always try latest nightly?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should say to check the release notes, as the rust versions are pinnned to the release that our clean room machine builds our binaries with that successfully work

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the Rust compiler recommendations and suggested to check out the release notes for the exact version if one runs into the compilation errors.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we use new Rust features almost as quickly as they come out so I think it's probably better to do what Shawn is suggesting: go with the latest nightly.

Copy link
Copy Markdown
Contributor Author

@ggwpez ggwpez Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put in in here #3653

Copy link
Copy Markdown
Contributor

@wpank wpank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add a short section on how to run and interpret the ./polkadot benchmark machine command, so that people can compare their machines with the reference hardware. Besides that, this looks good to me.

Comment on lines +306 to +308
rustup install nightly-2022-05-18
rustup target add wasm32-unknown-unknown --toolchain nightly-2022-05-18
cargo +nightly-2022-05-18 build --release
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should say to check the release notes, as the rust versions are pinnned to the release that our clean room machine builds our binaries with that successfully work

bakhtin added 2 commits August 8, 2022 09:53
Signed-off-by: bakhtin <a@bakhtin.net>
Signed-off-by: bakhtin <a@bakhtin.net>
@ggwpez ggwpez marked this pull request as ready for review August 8, 2022 09:16
@ggwpez ggwpez changed the title [Dont merge] Update reference hardware Update reference hardware Aug 8, 2022
@ggwpez
Copy link
Copy Markdown
Contributor Author

ggwpez commented Aug 8, 2022

@DrW3RK should be ready for a review now. Please let us know what you think.

@DrW3RK DrW3RK added A2 - Please Review Pull request is ready for review. and removed A0 - Do Not Merge Pull request should not yet be merged. labels Aug 8, 2022
Copy link
Copy Markdown
Member

@DrW3RK DrW3RK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor fixes and suggestions. Hopefully, they did not change the context or mess with the intended ideas.

Comment thread docs/maintain/maintain-guides-how-to-validate-polkadot.md Outdated
Comment thread docs/maintain/maintain-guides-how-to-validate-polkadot.md Outdated
Comment thread docs/maintain/maintain-guides-how-to-validate-polkadot.md Outdated
Comment thread docs/maintain/maintain-guides-how-to-validate-polkadot.md Outdated
Comment thread docs/maintain/maintain-guides-how-to-validate-polkadot.md Outdated
Comment thread docs/maintain/maintain-guides-how-to-validate-polkadot.md Outdated
Comment thread docs/maintain/maintain-guides-how-to-validate-polkadot.md Outdated
Comment thread docs/maintain/maintain-guides-how-to-validate-polkadot.md Outdated
Comment thread docs/maintain/maintain-guides-how-to-validate-polkadot.md Outdated
Comment thread docs/maintain/maintain-guides-how-to-validate-polkadot.md Outdated
Signed-off-by: bakhtin <a@bakhtin.net>
@bakhtin
Copy link
Copy Markdown
Contributor

bakhtin commented Aug 9, 2022

@DrW3RK I addressed all of your comments.
Can someone, please, approve running a workflow for the PR as GH restricts running it for the first-time contributors?

@DrW3RK DrW3RK merged commit 22feccc into w3f:master Aug 9, 2022
@DrW3RK
Copy link
Copy Markdown
Member

DrW3RK commented Aug 9, 2022

The validator docs are live now https://guide.kusama.network/docs/maintain-guides-how-to-validate-kusama
https://wiki.polkadot.network/docs/maintain-guides-how-to-validate-polkadot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A2 - Please Review Pull request is ready for review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants