Skip to content

Application: "SubIdentity" - Substrate Identity Directory#877

Merged
Noc2 merged 3 commits intow3f:masterfrom
TDSoftware:master
Apr 1, 2022
Merged

Application: "SubIdentity" - Substrate Identity Directory#877
Noc2 merged 3 commits intow3f:masterfrom
TDSoftware:master

Conversation

@s-dobschal
Copy link
Copy Markdown
Contributor

Project Abstract

SubIdentity is a fully client-side web application build with Vue.js in Typescript. The application enables searching of on-chain identities by any identity field in a substrate-based chain that implements the identity pallet.

For which grant level are you applying?

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $50,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for > $100k Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied, renamed ( project_name.md) and updated.
  • A BTC or Ethereum (DAI/USDT) address for the payment of the milestones is provided inside the application.
  • I have read and acknowledged the terms and conditions.
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 22, 2022

CLA assistant check
All committers have signed the CLA.

@semuelle semuelle self-assigned this Mar 22, 2022
Copy link
Copy Markdown
Contributor

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the application, @a-oertel. It looks very promising. A few minor questions/requests:

  • The RFP mentions IPFS multiple times, e.g. "allow users to enter their pinata key, and store set of fetched information to IPFS and pin on pinata", but your application doesn't. I personally think it would be great if I could store data and settings on IPFS. Are you not planning on including this? We have had several grants implement similar functionality, so if you want I could point you to one.
  • Milestone 4 of the RFP, a combination of documentation and maintenance, is not included. At this point we have specialised maintenance grants, so that part of the milestone could be agreed upon later. But if we leave out the maintenance part, we really need thorough documentation to ensure that it is usable and extendable for everyone for a while.
  • Sending tokens requires a wallet connection. Given that the RFP highlights mobile use, have you put any thought into supporting more than just polkadot.js?

@s-dobschal
Copy link
Copy Markdown
Contributor Author

Thanks for your feedback @semuelle

  • As part of the second milestone we plan on focussing on performance improvement. I specified that step to point out, that we plan on providing a caching option to IPFS.
  • We included number 0b in every milestone in order to record, that we will provide thorough documentation and an updated tutorial with every step. I've expanded the future plans chapter to signal our readiness for maintenance tasks beyond the scope of the project.
  • We plan on using an open protocol (e.g. wallet connect) to establish a secure connection to a wallet. This also allows connections to a wallet on mobile devices.

@semuelle
Copy link
Copy Markdown
Contributor

Thanks for the update, @a-oertel. I will share your application with the rest of the team.

@semuelle semuelle added the ready for review The project is ready to be reviewed by the committee members. label Mar 23, 2022
@SBalaguer
Copy link
Copy Markdown

Thanks @a-oertel for the submission! It seems like the mokups that are part of the submissions are the same as the Shard's Lab Identity Hub. If this is the case, would you mind providing your own UI mockups? For these type of grants its good to have a very draft first initial mockup to visualize better what you are going after.

Thanks!

@s-dobschal
Copy link
Copy Markdown
Contributor Author

Thanks @a-oertel for the submission! It seems like the mokups that are part of the submissions are the same as the Shard's Lab Identity Hub. If this is the case, would you mind providing your own UI mockups? For these type of grants its good to have a very draft first initial mockup to visualize better what you are going after.

Thanks!

Hey @SBalaguer, we created our own Mockups. You can view them here:
https://tdsoftware-dev.de/subidentity/home.png
https://tdsoftware-dev.de/subidentity/search-results.png
https://tdsoftware-dev.de/subidentity/profile-details.png
Could you please clarify what you mean exactly?

@SBalaguer
Copy link
Copy Markdown

For sure! And I might be missing something, but when I go to the Shard's Lab Identity Hub repository, I see this figma link that has the same (or at least very similar) mockups. That's where my confusion lies.

Copy link
Copy Markdown
Contributor

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to agree with Santiago, in general, it’s seem like your application is mostly based on the previous application: https://github.com/w3f/Grants-Program/blob/master/applications/substrate-identity-directory.md, but at a higher price, even though I think you can reuse some of the previous work by shard labs (also VUE, same design etc.). So do you plan on reusing the previous code base, (which is completely fine)? Also what are your long-term plans with this project? Could you expand on this?

@s-dobschal
Copy link
Copy Markdown
Contributor Author

It seems that the previous solution had performance issues (Evaluation) that we want to avoid. We're eager to find a more sensible solution and therefore we hesitate to continue using the code base.

Regarding the design: The designs/mockups look similar. This is because they are based on the same requirements of the RFP and we also chose pink as the main color to match the polkadot design.
Further our design addresses some of the issues with the previous design, for example:

  • Having the search box and the list view appear together on the landing page detracts from the search box's attention. We solve this by making it a central element in the landing page and adding a separate list view.
  • It was unclear how a closed column could be reopened. We, on the other hand, rely on an intuitive folding solution.
    On request, we can provide you with additional mockups of planned pages and components.

As mentioned before, we are very interested in doing maintenance work for the project. The development of additional plugins to extend the solution is also an option for us, as we plan to expand our open source activities.

@s-dobschal s-dobschal requested a review from Noc2 March 24, 2022 15:32
Copy link
Copy Markdown
Contributor

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick reply. I have one additional question, just to double check: have you considered potentially also developing a backend. A fully client side solution might be rather slow.

@s-dobschal
Copy link
Copy Markdown
Contributor Author

We considered developing a backend for performance reasons, but the RFP specifically calls for a fully client-side application. Therefore, we did not further investigate this approach. We definitely have the know-how and will keep the option in mind to put a server layer e.g. with Node.js in between the web app and the blockchain.

@s-dobschal s-dobschal requested a review from Noc2 March 25, 2022 09:38
Noc2
Noc2 previously approved these changes Mar 25, 2022
Copy link
Copy Markdown
Contributor

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I’m happy to go ahead with it.

semuelle
semuelle previously approved these changes Mar 25, 2022
@alxs
Copy link
Copy Markdown
Contributor

alxs commented Mar 25, 2022

For what it's worth, I don't think it's that important that this is a fully client-side application and I'm certain you will have performance issues if you don't do any indexing before. The last project did and still had issues. For some features, I don't see this working without a backend since you need to query the chain for specific events. Since you say you want to focus on usability and avoid performance issues, maybe you want to rethink that. I'm also curious as to what and how you intend to cache to IPFS.

@s-dobschal
Copy link
Copy Markdown
Contributor Author

Thanks for your input @alxs. We will look into this more closely and get back to you next week.

Copy link
Copy Markdown
Contributor

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a-oertel thanks a lot for this well-formulated application. 👍
I'm very happy with its scope and contents, but the pricing seems a bit high to me.
While I have nothing to criticize on M1 where most of the implementation seems to take place, the pricing of M2 and M3 seems to be a bit high. For example, M2.1 and M2.2 are probably limited to making the (probably previously hardcoded) node uri configurable and adding a simple form to add and select the node. M2.3 seems quite straightforward as well: parsing the values and applying them to the sorting function. Hence, I would have expected M2 to be a bit less pricy than M1. Also, M3 seems to be of similar complexity as M2. Therefore, I'd have expected M2 and M3 to be a bit cheaper.
Please feel to correct me if I'm wrong or if I'm overlooking something here. Also, feel free to lower the price of M2 and M3. Looking forward to your reply. :)

@s-dobschal s-dobschal dismissed stale reviews from semuelle and Noc2 via 1411b39 March 29, 2022 06:29
@s-dobschal
Copy link
Copy Markdown
Contributor Author

Hey @alxs, in response to your input, we included the development of a backend in our application. Please check our recent changes.

@s-dobschal
Copy link
Copy Markdown
Contributor Author

Hey @takahser, we changed the scope of our application based on @alxs comment. M2 includes the complete initial development of a backend to increase performance and to enable the implementation of features of the next milestone that require the chain to be queried for specific events. This leads to efforts that justify the original estimation. With that in mind, we've moved the implementation of the send tokens feature to M3. This also expanded its scope. In addition the implementation of the plugins governance, treasury and validator is not trivial and should be done with appropriate thoroughness. To deliver a high quality solution we also added a quality assurance step in M3.

@s-dobschal s-dobschal requested a review from takahser March 29, 2022 06:36
@s-dobschal s-dobschal requested review from Noc2 and semuelle March 29, 2022 06:37
Copy link
Copy Markdown
Contributor

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

Copy link
Copy Markdown
Contributor

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@s-dobschal
Copy link
Copy Markdown
Contributor Author

Hey @takahser, could you please take a look at our recent changes?

Copy link
Copy Markdown
Contributor

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a-oertel given the updated scope, I'm willing to go ahead with it as well! Good luck, looking forward to your delivery! 👍

@Noc2 Noc2 merged commit 47da817 into w3f:master Apr 1, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2022

Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions.

Before you start, take a moment to read through our announcement guidelines for all communications related to the grant or make them known to the right person in your organisation. In particular, please don't announce the grant publicly before at least the first milestone of your project has been approved. At that point or shortly before, you can get in touch with us at grantsPR@web3.foundation and we'll be happy to collaborate on an announcement about the work you’re doing.

Lastly, please remember to let us know in case you run into any delays or deviate from the deliverables in your application. You can either leave a comment here or directly request to amend your application via PR. We wish you luck with your project! 🚀

xgreenx pushed a commit to Supercolony-net/Open-Grants-Program that referenced this pull request Apr 29, 2022
* Create SubIdentity.md

* Minor proposal modifications

* Update SubIdentity.md
xgreenx pushed a commit to Supercolony-net/Open-Grants-Program that referenced this pull request Jun 16, 2022
* Create SubIdentity.md

* Minor proposal modifications

* Update SubIdentity.md
@s-dobschal
Copy link
Copy Markdown
Contributor Author

SubIdentity milestone 3 delivery will be delayed because of the current vacation time in the team. Delivery is expected in mid of August. If any questions come up, feel free to ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review The project is ready to be reviewed by the committee members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants