Application: "SubIdentity" - Substrate Identity Directory#877
Application: "SubIdentity" - Substrate Identity Directory#877Noc2 merged 3 commits intow3f:masterfrom
Conversation
semuelle
left a comment
There was a problem hiding this comment.
Thanks for the application, @a-oertel. It looks very promising. A few minor questions/requests:
- The RFP mentions IPFS multiple times, e.g. "allow users to enter their pinata key, and store set of fetched information to IPFS and pin on pinata", but your application doesn't. I personally think it would be great if I could store data and settings on IPFS. Are you not planning on including this? We have had several grants implement similar functionality, so if you want I could point you to one.
- Milestone 4 of the RFP, a combination of documentation and maintenance, is not included. At this point we have specialised maintenance grants, so that part of the milestone could be agreed upon later. But if we leave out the maintenance part, we really need thorough documentation to ensure that it is usable and extendable for everyone for a while.
- Sending tokens requires a wallet connection. Given that the RFP highlights mobile use, have you put any thought into supporting more than just polkadot.js?
|
Thanks for your feedback @semuelle
|
|
Thanks for the update, @a-oertel. I will share your application with the rest of the team. |
|
Thanks @a-oertel for the submission! It seems like the mokups that are part of the submissions are the same as the Shard's Lab Identity Hub. If this is the case, would you mind providing your own UI mockups? For these type of grants its good to have a very draft first initial mockup to visualize better what you are going after. Thanks! |
Hey @SBalaguer, we created our own Mockups. You can view them here: |
|
For sure! And I might be missing something, but when I go to the Shard's Lab Identity Hub repository, I see this figma link that has the same (or at least very similar) mockups. That's where my confusion lies. |
Noc2
left a comment
There was a problem hiding this comment.
I have to agree with Santiago, in general, it’s seem like your application is mostly based on the previous application: https://github.com/w3f/Grants-Program/blob/master/applications/substrate-identity-directory.md, but at a higher price, even though I think you can reuse some of the previous work by shard labs (also VUE, same design etc.). So do you plan on reusing the previous code base, (which is completely fine)? Also what are your long-term plans with this project? Could you expand on this?
|
It seems that the previous solution had performance issues (Evaluation) that we want to avoid. We're eager to find a more sensible solution and therefore we hesitate to continue using the code base. Regarding the design: The designs/mockups look similar. This is because they are based on the same requirements of the RFP and we also chose pink as the main color to match the polkadot design.
As mentioned before, we are very interested in doing maintenance work for the project. The development of additional plugins to extend the solution is also an option for us, as we plan to expand our open source activities. |
Noc2
left a comment
There was a problem hiding this comment.
Thanks for the quick reply. I have one additional question, just to double check: have you considered potentially also developing a backend. A fully client side solution might be rather slow.
|
We considered developing a backend for performance reasons, but the RFP specifically calls for a fully client-side application. Therefore, we did not further investigate this approach. We definitely have the know-how and will keep the option in mind to put a server layer e.g. with Node.js in between the web app and the blockchain. |
Noc2
left a comment
There was a problem hiding this comment.
Thanks. I’m happy to go ahead with it.
|
For what it's worth, I don't think it's that important that this is a fully client-side application and I'm certain you will have performance issues if you don't do any indexing before. The last project did and still had issues. For some features, I don't see this working without a backend since you need to query the chain for specific events. Since you say you want to focus on usability and avoid performance issues, maybe you want to rethink that. I'm also curious as to what and how you intend to cache to IPFS. |
|
Thanks for your input @alxs. We will look into this more closely and get back to you next week. |
takahser
left a comment
There was a problem hiding this comment.
@a-oertel thanks a lot for this well-formulated application. 👍
I'm very happy with its scope and contents, but the pricing seems a bit high to me.
While I have nothing to criticize on M1 where most of the implementation seems to take place, the pricing of M2 and M3 seems to be a bit high. For example, M2.1 and M2.2 are probably limited to making the (probably previously hardcoded) node uri configurable and adding a simple form to add and select the node. M2.3 seems quite straightforward as well: parsing the values and applying them to the sorting function. Hence, I would have expected M2 to be a bit less pricy than M1. Also, M3 seems to be of similar complexity as M2. Therefore, I'd have expected M2 and M3 to be a bit cheaper.
Please feel to correct me if I'm wrong or if I'm overlooking something here. Also, feel free to lower the price of M2 and M3. Looking forward to your reply. :)
|
Hey @alxs, in response to your input, we included the development of a backend in our application. Please check our recent changes. |
|
Hey @takahser, we changed the scope of our application based on @alxs comment. M2 includes the complete initial development of a backend to increase performance and to enable the implementation of features of the next milestone that require the chain to be queried for specific events. This leads to efforts that justify the original estimation. With that in mind, we've moved the implementation of the send tokens feature to M3. This also expanded its scope. In addition the implementation of the plugins governance, treasury and validator is not trivial and should be done with appropriate thoroughness. To deliver a high quality solution we also added a quality assurance step in M3. |
|
Hey @takahser, could you please take a look at our recent changes? |
takahser
left a comment
There was a problem hiding this comment.
@a-oertel given the updated scope, I'm willing to go ahead with it as well! Good luck, looking forward to your delivery! 👍
|
Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions. |
* Create SubIdentity.md * Minor proposal modifications * Update SubIdentity.md
* Create SubIdentity.md * Minor proposal modifications * Update SubIdentity.md
|
SubIdentity milestone 3 delivery will be delayed because of the current vacation time in the team. Delivery is expected in mid of August. If any questions come up, feel free to ask. |
Project Abstract
SubIdentity is a fully client-side web application build with Vue.js in Typescript. The application enables searching of on-chain identities by any identity field in a substrate-based chain that implements the identity pallet.
For which grant level are you applying?
Application Checklist
project_name.md) and updated.