Skip to content

SubIdentity milestone 2 delivery#463

Merged
Noc2 merged 1 commit intow3f:masterfrom
TDSoftware:master
Jun 20, 2022
Merged

SubIdentity milestone 2 delivery#463
Noc2 merged 1 commit intow3f:masterfrom
TDSoftware:master

Conversation

@s-dobschal
Copy link
Copy Markdown
Contributor

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#877

@lucasvanmol lucasvanmol self-assigned this Jun 15, 2022
@lucasvanmol
Copy link
Copy Markdown
Contributor

Hi there @a-oertel , the delivery is looking great so far.

I just have a question regarding the offline mode deliverable - I saw in the README that connecting to a custom node can only be done for wss:// addresses when connected to a https:// endpoint. I did manage to connect to a local node (with a ws:// address) when running the webapp on localhost (http://) but, as expected, got an error when trying to do the same while connected to https://subidentity.tdsoftware.de/.

Sorry if I'm misunderstanding something obvious, but I'm just curious why it would not be possible to connect to a ws:// node from the https host, like what's possible with polkadot.js.org/apps, for example.

@s-dobschal
Copy link
Copy Markdown
Contributor Author

Hey @lucasvanmol,
thanks for the quick response to our delivery. I'm not sure how polkadot.js.org/apps handles this, but in general modern browsers don't allow a connection from a page loaded over HTTPS to an insecure WebSocket endpoint. We will provide an HTTP-only version for you to connect your local node to. I will inform you when it is available.

@lucasvanmol
Copy link
Copy Markdown
Contributor

No worries about hosting an http version, I was just curious :)

Copy link
Copy Markdown
Contributor

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! Your milestone 2 was just accepted, see #467

@Noc2 Noc2 merged commit d6209dc into w3f:master Jun 20, 2022
failfmi pushed a commit to LimeChain/Grant-Milestone-Delivery that referenced this pull request Sep 26, 2022
expand deliverables on Milestone 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants