Skip to content

Polk-auction#452

Merged
Noc2 merged 3 commits intow3f:masterfrom
CrommVardek:master
Jul 5, 2021
Merged

Polk-auction#452
Noc2 merged 3 commits intow3f:masterfrom
CrommVardek:master

Conversation

@CrommVardek
Copy link
Copy Markdown
Contributor

@CrommVardek CrommVardek commented Jun 10, 2021

Grant Application Checklist

  • The application template has been copied, renamed ( project_name.md) and updated.
  • A BTC or Ethereum (DAI) address for the payment of the milestones is provided inside the application.
  • I have read and acknowledged the Terms and Conditions.
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The total funding amount of the project is below USD $30k for initial grant applications and $100k for follow-up grants.
  • The initial PR contains only one commit (squash if needed before submitting your PR).
  • The grant will only be announced once the first milestone has been accepted.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 10, 2021

CLA assistant check
All committers have signed the CLA.

@mmagician mmagician self-assigned this Jun 11, 2021
@mmagician
Copy link
Copy Markdown
Contributor

mmagician commented Jun 11, 2021

@CrommVardek This looks good! It does seem that you pushed commits with two different accounts, and they will both need to sign the CLA License before we can proceed.

Alternatively you can force-push to your branch from just one account that has signed it.

@mmagician
Copy link
Copy Markdown
Contributor

In addition, the PR header contains some check-boxes which seem unchecked now. Please ensure they're ticked, as it shows us that you read & understood the conditions of the process.

@CrommVardek
Copy link
Copy Markdown
Contributor Author

Hello @mmagician, indeed the boxes were not checked, still have one to check. Thanks for the tips about the CLA, I'll squash the commits and force push with my github account later today.

@alxs
Copy link
Copy Markdown
Contributor

alxs commented Jun 11, 2021

Hey @CrommVardek, thanks for the application. I think you've correctly identified the need for such a website, but unfortunately so have others in the ecosystem before. See https://www.parachains.network/ or https://www.subvis.io/, and I expect more similar websites will appear in the near future. For this reason I'm sorry to say I'd rather not support the application, but maybe you could combine efforts with @jhonalino to work on parachains.network? I don't know if his work is currently being funded at all and he may be happy to apply for a grant as well.

@CrommVardek
Copy link
Copy Markdown
Contributor Author

Hi @alxs, thanks for your feed-back. I was indeed expecting others to be faster than I am to publish similar websites. Even though when I started the project none were released yet (well polkadot.js was... but that is not its focus). As I previously discussed by e-mail with @Noc2 , my application for an open-grant was mainly to be able to financially support the hosting costs on a dedicated server. My plan is still to continue this project or, as you suggest - and that is a good idea - join efforts made by faster developers :)

@alxs
Copy link
Copy Markdown
Contributor

alxs commented Jun 11, 2021

Sounds good, in that case I'll share with the rest of the committee :)

@alxs alxs added the ready for review The project is ready to be reviewed by the committee members. label Jun 11, 2021
Copy link
Copy Markdown
Contributor

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the application. In general I personally think it makes sense to support multiple UI focused projects. But I have a few questions.

  • Why do you want to work on a HTTP Rest API in Kotlin? You can take a look at existing solutions here: https://github.com/w3f/General-Grants-Program/blob/master/grants/polkadot_stack.md So far, we only had one other Kotlin based project. That’s said a full kotlin client could potentially be a separate grant project (would you be interested in this?).
  • Do you already have an initial designs for the UI? Or potentially other UI focused projects, which you can share? To be honest, the drawings are not really nice looking at the moment ;-)

@CrommVardek
Copy link
Copy Markdown
Contributor Author

Hi @Noc2, thanks for the feed-back, to answer your questions :

  • Regarding the choice of Kotlin, at first I planned to use Java then realized Kotlin is easier to read and write, lightweight to deploy. And Kotlin feels (to me at least) closer to Rust or Go than Java. Indeed, a kotlin client could be a good idea for a separate project, however isn't there already a java client ? (I mean, both could co-exists, but it feels less useful to have a kotlin client when a java one is maintained).
  • I've not worked on the ui yet, and sadly the UI-focused projects I've worked on are not public neither open-source, so I cannot share them. I'll focus on a first draft of the UI, commit & push the code and update this application with screenshot(s) to give you a better idea of the UI.

Hope this answer your questions !

@Noc2
Copy link
Copy Markdown
Contributor

Noc2 commented Jun 14, 2021

Thanks for a quick response. You can find the java client here and indeed it might make more sense to contribute to this client instead of creating your own client. But we generally are interested in supporting a wide variety of implementations. Let me know once you added a screenshot to the application.

@mmagician
Copy link
Copy Markdown
Contributor

mmagician commented Jun 17, 2021

it is not intended to integrate functionalities such as:
Using the website as a way to participate in crowdloans
Using the website to participate to the auction

That's a shame. Maybe as my colleagues have suggested, more net utility could be achieved by teaming up with another existing project and integrating the interactive functionality of the parachains that you mention, which is currently also missing from the "competition".

@paxelpixel
Copy link
Copy Markdown

Hey @CrommVardek, thanks for the application. I think you've correctly identified the need for such a website, but unfortunately so have others in the ecosystem before. See https://www.parachains.network/ or https://www.subvis.io/, and I expect more similar websites will appear in the near future. For this reason I'm sorry to say I'd rather not support the application, but maybe you could combine efforts with @jhonalino to work on parachains.network? I don't know if his work is currently being funded at all and he may be happy to apply for a grant as well.

hey @alxs, thank you so much for the mention of my project parachains.network I'm definitely happy and been planning to apply for a grant. @CrommVardek I've read your application. it looks like your stack requires a layer of a backend server. I'm mostly focusing parachains.network to be a static client like polkadot.js where it connects directly to a polkadot/kusama node via websockets. but message me if you'd like to work together. I'll be happy to rethink the structure for a better UX. (I'm mostly a frontend dev.)

I also have another project if you're interested like
https://polkaview.network/dot/identities to browse Polkadot/kusama identities
https://www.stakingrewards.network/ to calculate staking rewards.
both require indexing to traditional databases to dramatically improve query performance.

@CrommVardek
Copy link
Copy Markdown
Contributor Author

@mmagician : TBH I don't have the needed skills to develop a solution to add such functionalities - but of course, I can learn and later add those features that, as you mention, are not present in other project (outside of polkadot.js app). So it's something I might consider in the future but that's definitely out of the scope of this application.

Hi @jhonalino, thanks for your reply, indeed the UI would need a back-end, the reason is to facilitate the (indirect) connection to the nodes and add off-chain information, so the UI has only one API endpoint to connect to. I've take a look at your repo already, and indeed I noticed that you connect to the public nodes directly (in that you avoid running a backend which avoids some hassle). As I'm mostly a back-end developer, working together would be nice. I'll message you in a few days to see how we can work together and what I can do.

@mmagician
Copy link
Copy Markdown
Contributor

@CrommVardek Sure, I see your point. Seeing that there is potential for a collaboration between yourself and @jhonalino, I'll put this PR on hold, does that make sense?
Perhaps the two of you decide to unite forces and leverage back+frontend skills. I would rather fund the addition of a back-end to the existing solution.

Let us know if in the end you prefer to continue with the current scope and we'll resume the evaluation.

@mmagician mmagician added on hold There is an external blocker, such as another grant in progress. and removed ready for review The project is ready to be reviewed by the committee members. labels Jun 17, 2021
@alxs
Copy link
Copy Markdown
Contributor

alxs commented Jun 17, 2021

@jhonalino https://www.stakingrewards.network/ looks really good. Are you aware of this RFP and matching proposal? We could potentially also fund improvements to it. Also tagging @jonasW3F who developed the original staking rewards collector, as he may not even be aware of your work.

Also regarding https://polkaview.network/dot/identities: see #255. You should consider applying for grants more often ;)

And future plans changes.
@CrommVardek
Copy link
Copy Markdown
Contributor Author

Hi @alxs, I've updated the application with a some UI to give you a better idea of what I had in mind. This is for now very basic UI. I'll keep updating as I'm working on the UI (also, feel free to take a look at the corresponding repositories).

@jhonalino I've sent you an email - however I'm not sure it was the right channel to message you. So I'm tagging you here... ^^'

@Noc2 I've taken a closer look at the java client, I must admit I'm not really fan of the implementation, so I'm going to develop a kotlin WS client for the Polkadot nodes specifically for this project. And I plan to extend it later to have something that could be used like the @polkadot/api, and eventually making an application for it.

@mmagician
Copy link
Copy Markdown
Contributor

@CrommVardek Thanks for the updated mock ups.
As I already mentioned, I would still rather support the integration of a backend to an existing implementation, since I don't see additional benefits of another implementation if it has the same functionality as other existing pages.
However, given that you are willing to work on the Kotlin client implementation alongside the webpage, I would be open to go ahead with a project that uses it as the backend. With the current status of the application, I don't fully understand whether you'll be developing some parts of the Kotlin client in parallel, or whether they'll be done afterwards?
Perhaps you could specify the functionality of the client that you're planning to finish by each milestone?

@CrommVardek
Copy link
Copy Markdown
Contributor Author

@mmagician Thanks, indeed I was probably not clear.

My intent is to continue developing the back-end but add a kotlin client that I would develop some parts only (parts that I'd need for the backend) and in the scope of this application. Later on - if I believe that client can be usuful, I'd like to develop a more complete version of it, but I keep that outside of the scope of this application.

However, as you suggest, I'll update the application to be more specific about that kotlin client so you know where it's going and what I plan to do.

@CrommVardek
Copy link
Copy Markdown
Contributor Author

@mmagician I've updated the application to clarify the way I intend to develop and use a kotlin WS client for Polkadot/Substrate nodes. I may have missed some points, so if you still have question, doubts or just want more information, feel free to ask :)

Copy link
Copy Markdown
Contributor

@mmagician mmagician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, sounds good. Then I wish you good luck and I will be looking forward to your deliverables!

Copy link
Copy Markdown
Contributor

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see a complete Kotlin client, so I'm approving this in hopes of a follow-up grant. :)

@Noc2 Noc2 merged commit 4c29ecb into w3f:master Jul 5, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 5, 2021

Congratulations! As part of the Open Grants Program, we want to help winning teams acknowledge their grants publicly. To that end, we’ve created a badge for projects that successfully delivered their first milestone. Please observe the foundation’s guidelines when making any announcements; in particular, don’t announce the grant publicly before you've completed at least the first milestone of the project.

At that point, we will be happy to collaborate on an announcement about the work you’re doing. Please get in touch with us at grantspr@web3.foundation in case you're interested (at least two weeks notice is preferred).

@CrommVardek
Copy link
Copy Markdown
Contributor Author

@Noc2 , @mmagician , @semuelle Thanks for trusting me and approving this application : )

@semuelle semuelle removed the on hold There is an external blocker, such as another grant in progress. label Aug 25, 2021
chrisli30 pushed a commit to AvaProtocol/W3F-Grants-Fork that referenced this pull request Oct 8, 2021
* squash

* Update with UI mock-ups
And future plans changes.

* Add details about the websocket.
@semuelle
Copy link
Copy Markdown
Contributor

Hey @CrommVardek, how is the project progressing? Are you still on track for the second milestone?

@CrommVardek
Copy link
Copy Markdown
Contributor Author

Hi @semuelle , yes, the second milestone is almost done actually, I need to finish a few things, add tests and documentation. I do not have much time for this project sadly, but I plan to end the second milestone before the end of this year, and then the last milestone should be relatively trivial.

@semuelle
Copy link
Copy Markdown
Contributor

That's great to hear. It's no problem if it's postponed by a few weeks, we'd rather see things done well than fast. :) Feel free to post here if you want to give an update outside milestone deliveries.

@alxs
Copy link
Copy Markdown
Contributor

alxs commented Jan 6, 2022

@CrommVardek friendly reminder, what's the status on your end?

@CrommVardek
Copy link
Copy Markdown
Contributor Author

Hi @alxs , some UX testing and small changes are still made to have a finer working UI (milestone 2). Basically it is done (except for the dockerfile - deliverable 0d.), but I'd like to change few thing before publishing the next delivery. If it becomes an issue to delay further the milestone 2, I'll publish it this week and make my small changes later on another release.

@alxs
Copy link
Copy Markdown
Contributor

alxs commented Jan 6, 2022

Thanks for the update. No worries, feel free to take care of those changes before you submit.

@CrommVardek
Copy link
Copy Markdown
Contributor Author

Hey, for information I've almost finish polishing UI, however I'm dependent of this issue to be solved to regarding the backend : paritytech/substrate-api-sidecar#814 (as I use sidecar for some of the information related to the auction). Once this is resolved I should post for the 2nd delivery milestone a few days later.

@Noc2
Copy link
Copy Markdown
Contributor

Noc2 commented Jan 20, 2022

Thanks a lot for the update.

@semuelle
Copy link
Copy Markdown
Contributor

Hey @CrommVardek, just checking in here. Based on your Github activity, I can assume that you are still working on milestone 3?

@CrommVardek
Copy link
Copy Markdown
Contributor Author

Hi @semuelle , that's correct, milestone 3 is close to be done, the project is already online at www.polkauction.io, but there are a few things I'd like to verify and change before submitting the 3rd milestone (most important is setting up SSL and correcting a UI bug). I should open the 3rd delivery by the end of this month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants