PolkAuction - milestone 1

[CrommVardek]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• The invoice form 📝 has been filled out for this milestone.
• This pull request is being made by the same account as the accepted application.
• In case of acceptance, the payment will be transferred to the BTC/ETH payment address provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#452

[alxs]

Hi @CrommVardek, thank you for the delivery. Please submit an amendment if you want to modify the deliverables in this milestone (or perhaps remove it altogether if there's nothing for you to deliver? You can distribute the cost across the remaining milestones as far as I'm concerned).

[CrommVardek]

Hi @alxs, the functionalities remain the same as in the application's delivery, it is a note regarding the technical aspects of it. During the application I changed it to add a custom WS to avoid using sidecar-api. However as I greatly underestimate the development of a WS as a node API, I've decided to stick to sidecar (for now). So basically in terms of functionalities, nothing changes.

However if you still prefer that I commit an amendment to the application, I can do that.

[alxs]

I see. That may be fine without amendment, I'll leave it up to the person evaluating your delivery. Could you just add a link pointing to where each of the deliverables is implemented?

[alxs]

Btw, if this is something you still want to look into, the following may be useful: https://github.com/scs/substrate-api-client

[CrommVardek]

Hi @alxs, sure, I'll add the links.

Thanks for the link on the api client, indeed it might be useful !

[semuelle]

Hey Cyril, your milestone is hereby accepted. 🎉

I don't see an issue with using sidecar. The only issue I had was finding the right Java version to compile the project (JDK 11, 13 and 16.0.1 failed; 15.0.2 works). Also, the endpoint was exposed under 127.0.100.1, not localhost as the readme suggested. Would be great if you could look into JDK 16 compatibility and maybe fix the readme or default config. Evaluation notes here.

I will forward your invoice for processing.

[CrommVardek]

Hi @semuelle ,

Thank you for the evaluation. Indeed I had not tested with Java15 nor 16 - only with JDK 14. I'll look into JDK16 compatibility.

You are correct, the endpoint url is incorrect in the readme. The default configuration is correct (localhost) however the documentation should make the distinction between the docker endpoint (127.0.100.1) and the local endpoint (localhost). But I think I should keep the same endpoint regardless the API is running on docker or not.

I've a question regarding the badge. As I understand, under the new grants program, level 1 application cannot use the badge. However when the polk-auction application was merged, it was mentioned I could use the badge once the first delivery is accepted. So now, I don't know if I can (or not) use that badge on the github page of the project ?

[semuelle]

I've a question regarding the badge. As I understand, under the new grants program, level 1 application cannot use the badge. However when the polk-auction application was merged, it was mentioned I could use the badge once the first delivery is accepted. So now, I don't know if I can (or not) use that badge on the github page of the project ?

Since your application was accepted before the introduction of levels, you are free to use the badge as per the guidelines.

[RouvenP]

hi @CrommVardek we just sent the payment. apologies for the delay.

[CrommVardek]

Hi @RouvenP , thanks, no problem.