Removing the BTC faucet functionality because BlueWallet does not support the Bitcoin testnet #1223
Merged
Noc2 merged 4 commits intow3f:masterfrom Oct 24, 2022
Merged
Removing the BTC faucet functionality because BlueWallet does not support the Bitcoin testnet #1223Noc2 merged 4 commits intow3f:masterfrom
Noc2 merged 4 commits intow3f:masterfrom
Conversation
|
|
Noc2
previously approved these changes
Oct 19, 2022
Contributor
Noc2
left a comment
Noc2
left a comment
There was a problem hiding this comment.
Thanks for the update. Sounds good to me. For reference: w3f/Grant-Milestone-Delivery#605
Noc2
added
the
ready for review
takahser
previously approved these changes
Oct 19, 2022
Contributor
|
Application PR: #868 |
alxs
approved these changes
Oct 19, 2022
alxs
approved these changes
Oct 19, 2022
Noc2
approved these changes
Oct 19, 2022
semuelle
approved these changes
Oct 19, 2022
takahser
approved these changes
Oct 19, 2022
keeganquigley
approved these changes
Oct 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to remove the BTC testnet faucet because of the signer configuration. We provided BTC secrets to the evaluator for use in testing.