Native Bitcoin Vaults Milestone #2 Delivery

[mgravitt]

Milestone Delivery Checklist

This video provides an end-to-end demonstration: https://us02web.zoom.us/rec/play/5d8024FYk5NwGPVncmDQklHjJkN9rJQTHjMIJR5g6s2uRCNXn31uzZhye-gegg55QBAONFYoqxJmiuNK.Wv8GfHCImD9ePKPw

• The milestone-delivery-template.md has been copied and updated.
• The invoice form 📝 has been filled out for this milestone.
• This pull request is being made by the same account as the accepted application.
• In case of acceptance, the payment will be transferred to the BTC/ETH payment address provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#868

[Noc2]

Sorry for the delay here. I just started to look into it. Could you potentially update some of the links, like nbv-storage or tests? They currently don’t work for me.

[Noc2]

Thanks for the quick update and sorry again for the delay here (Too many meetings). The delivery looks really good. I just have a couple of minor things:

• I had two failed tests, when I tried to run https://github.com/hashed-io/hashed-substrate/blob/main/pallets/bitcoin-vaults/src/tests.rs, see https://github.com/w3f/Grant-Milestone-Delivery/blob/master/evaluations/native-bitcoin-vaults-milestone_2_Noc2.md
• The following repos don’t have a license file: https://github.com/hashed-io/hashed-network-portal-ui and https://github.com/hashed-io/nbv-client-api

[mgravitt]

We fixed the tests. We changed the feature to auto-broadcast a transaction once the threshold of signatures has been met, and so that transaction was gone when the test was checking for it to be pending.

It's merged to the develop branch of https://github.com/hashed-io/hashed-substrate.

I added LICENSE files to the repos listed.

[Noc2]

Thanks for the super quick reply. I can confirm that everything works now and I’m happy to tell you that the milestone is approved. I will forward your invoice internally.

[Noc2]

@3yekn it looks like the address in the contract is different from the address on the invoice. Could you either update the invoice or the address in the contract? Thanks

[mgravitt]

@Noc2 ah, sorry, I just re-sent the invoice with the same address as the original grant. thx

[Noc2]

Thanks. I just forwarded the invoice internally.