Skip to content

Evaluation "polkadot js extension per account auth" milestone 1 #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Noc2 merged 3 commits into from
Jul 15, 2022
Merged

Evaluation "polkadot js extension per account auth" milestone 1 #502

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52ef38d
Init create eval file polkadot-js-extension-per-account-auth_1_CrommV…
CrommVardek Jul 14, 2022
c8b88ca
Finish eval of Privacy enhancement for Polkadot-js extension
CrommVardek Jul 14, 2022
e1d91c4
Fix eval file extension
CrommVardek Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions evaluations/polkadot-js-extension-per-account-auth_1_CrommVardek.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# Evaluation

- **Status:** Accepted
- **Application Document:** https://github.com/w3f/Grants-Program/blob/master/applications/polkadot-js-extension-per-account-auth.md
- **Milestone:** Number 1
- **Kusama Identity:** JCkD7cRTpfkQmk5v6XvWvR1JPTvrouPXSGmQqtWPcJQKFzx
- **Previously successfully merged evaluation:** N/A

| Number | Deliverable | Accepted | Link | Evaluation Notes |
| ------ | ----------- | -------- | ---- |----------------- |
| 0b. | Documentation | <ul><li>[ ] </li></ul>| | Missing Documentation |
| 0e. | Article | <ul><li>[ ] </li></ul>| | Missing Article |
| 1. | new approval screen |<ul><li>[x] </li></ul>| [PR](https://github.com/polkadot-js/extension/pull/1068) | |
| 2. | new approval back-end | <ul><li>[x] </li></ul>| [PR](https://github.com/polkadot-js/extension/pull/1068) | |
| 3. | website approval enhancement | <ul><li>[x] </li></ul>| [PR](https://github.com/polkadot-js/extension/pull/1068) | |
| 4. | Test implementation | <ul><li>[x] </li></ul> | [PR](https://github.com/polkadot-js/extension/pull/1068), [Commit](https://github.com/polkadot-js/extension/pull/1068/commits/cd3a40b33cfed9d4196472419e96fa71beffb58b) | Was not planned, but always nice to have added a test. |

Ideally all links inside the above table should include the commit hash,
which was used for testing the delivery. It should also be checked if the software is published under the correct open-source license.

## General Notes

As I'm not familiar with polkadot-js extension's source code, it was not straight forward to link the changed files to a delivery step (as all delivery steps are linekd to the same PR).
It would have been nice to maybe link the corresponding commit(s) instead of the same PR. Hopefully the files changes are not huge so it is still comprehensive and not too difficult to navigate through.

Missing article and documentation, not a big deal.