Skip to content

Evaluation "polkadot js extension per account auth" milestone 1 #502

Merged
Noc2 merged 3 commits intow3f:masterfrom
CrommVardek:eval-polkadot-js-extension-per-account-auth_1_CrommVardek
Jul 15, 2022
Merged

Evaluation "polkadot js extension per account auth" milestone 1 #502
Noc2 merged 3 commits intow3f:masterfrom
CrommVardek:eval-polkadot-js-extension-per-account-auth_1_CrommVardek

Conversation

@CrommVardek
Copy link
Copy Markdown
Contributor

Link to PR

Overall the features are well developed and has already been merged to the polkadot-js extension's master branch.

There are two missing steps of the delivery : the article and the documentation. Not problematic in my opinion. This is why I think the status should be accepted.

Copy link
Copy Markdown
Contributor

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the external evaluation. I’m going to merge it already. However, not sure I agree with the acceptance. I guess the PR including the video and inline documentation counts as documentation. But an article would have still been nice.

@Noc2 Noc2 merged commit 2dd5e37 into w3f:master Jul 15, 2022
@Noc2
Copy link
Copy Markdown
Contributor

Noc2 commented Jul 15, 2022

Fyi: I also informed the operations team about your external evaluation. Make sure your KSM address is correct.

@CrommVardek
Copy link
Copy Markdown
Contributor Author

@Noc2 : Thanks, I was hesitant to mark it as accepted, mostly because of the documentation honestly. Maybe I should have inform the PR author to update his delivery to include both the doc and the article before marking my evaluation as accepted - since then it has been done by takahser.

My KSM address is correct : )

@CrommVardek
Copy link
Copy Markdown
Contributor Author

@Noc2 : I'm unsure about the delay between the merging of an external evaluation and the transfer, but I have not received a transfer yet (https://kusama.subscan.io/account/JCkD7cRTpfkQmk5v6XvWvR1JPTvrouPXSGmQqtWPcJQKFzx?tab=transfer)

@Noc2
Copy link
Copy Markdown
Contributor

Noc2 commented Jul 27, 2022

Thanks for chasing us. I will ask the operation team about it.

@RouvenP
Copy link
Copy Markdown

RouvenP commented Jul 28, 2022

hi @CrommVardek thank you - the KSM will be sent tomorrow.

failfmi pushed a commit to LimeChain/Grant-Milestone-Delivery that referenced this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants