add action to deploy assets from PR and delete them when the PR is closed #159
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| on: | ||
| pull_request_target: | ||
| types: [opened, edited, reopened, synchronize] | ||
|
|
||
| jobs: | ||
| build_css: | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| source: public/dist/assets | ||
| destination: assets/website-2021/pr-${{ github.event.number }}/ | ||
|
There was a problem hiding this comment. Should we create a folder for all of them, rather than putting them directly under website-2021? There was a problem hiding this comment. we could use |
||
| steps: | ||
| - name: Checkout source Git branch | ||
| uses: actions/checkout@v2 | ||
| with: | ||
| ref: ${{github.event.pull_request.head.ref}} | ||
| persist-credentials: false | ||
|
|
||
| - name: Use Node.js | ||
| uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: '16' | ||
|
|
||
| - name: Install npm modules | ||
| run: npm install | ||
|
|
||
| - name: compile assets | ||
| run: npm run build | ||
|
|
||
| - name: Upload to cdn-dev.w3.org bucket | ||
| if: success() | ||
| env: | ||
| AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||
| AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
| AWS_REGION: 'us-east-1' | ||
| run: | ||
| aws s3 sync --no-progress ${{ env.source }} s3://cdn-dev.w3.org/${{ env.destination }} | ||
|
There was a problem hiding this comment. I don't know if we want to use cdn-dev or cdn. I think cdn-dev is restricted, and if so it may be difficult to show changes to external contributors. |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| on: | ||
| pull_request_target: | ||
| types: | ||
| - closed | ||
|
|
||
| jobs: | ||
| delete_assets: | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| destination: assets/website-2021/pr-${{ github.event.number }}/ | ||
| steps: | ||
| - name: Delete PR assets from the cdn-dev.w3.org bucket | ||
| if: success() | ||
| env: | ||
| AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||
| AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
| AWS_REGION: 'us-east-1' | ||
| run: | ||
| aws s3 rm --recursive s3://cdn-dev.w3.org/${{ env.destination }} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if deploying automatically is a good idea. It could be unsafe to deploy PRs opened by external contributors, so deploying manually might be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we could use
workflow_dispatchinstead to be on the safe side but we will need to run it manually each time the PR is updated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running manually seems fine to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might be able to trigger the action only on local PRs (so from branches on that repository) instead of PRs coming from forked repositories. How does that sound?