add action to deploy assets from PR and delete them when the PR is closed #159
Conversation
deniak
changed the title
| on: | ||
| pull_request_target: | ||
| types: [opened, edited, reopened, synchronize] |
There was a problem hiding this comment.
I wonder if deploying automatically is a good idea. It could be unsafe to deploy PRs opened by external contributors, so deploying manually might be better.
There was a problem hiding this comment.
yes, we could use workflow_dispatch instead to be on the safe side but we will need to run it manually each time the PR is updated.
There was a problem hiding this comment.
Running manually seems fine to me.
There was a problem hiding this comment.
I think we might be able to trigger the action only on local PRs (so from branches on that repository) instead of PRs coming from forked repositories. How does that sound?
| runs-on: ubuntu-latest | ||
| env: | ||
| source: public/dist/assets | ||
| destination: assets/website-2021/pr-${{ github.event.number }}/ |
There was a problem hiding this comment.
Should we create a folder for all of them, rather than putting them directly under website-2021?
There was a problem hiding this comment.
we could use assets/website-2021-dev/ to avoid mixing prod and dev assets.
| AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
| AWS_REGION: 'us-east-1' | ||
| run: | ||
| aws s3 sync --no-progress ${{ env.source }} s3://cdn-dev.w3.org/${{ env.destination }} |
There was a problem hiding this comment.
I don't know if we want to use cdn-dev or cdn. I think cdn-dev is restricted, and if so it may be difficult to show changes to external contributors.
That PR uploads assets from pull requests to cdn-dev.w3.org and deletes them when the PR is closed