fix: onHide error thrown on ESC press when <UpdateVersionModal /> is open
#1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stalgiag
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Odd! If that is true then there might be a regression in that library. Surely they aren't calling null props as functions?? Either way, this change is small on our end and seems less fragile to upstream problems. I am going to approve and merge so the problem doesn't wind its way to prod.
howard-e
added a commit
that referenced
this pull request
Jul 22, 2024
Includes the following changes: **Features and Fixes** * #1125 * #1135 * #1144 * #1146 * #1150 * #1152 * #1153 * #1160 **Infrastructure changes** * #969 * #1151 * #1148 --------- Co-authored-by: alflennik <[email protected]> Co-authored-by: Mx Corey Frang <[email protected]> Co-authored-by: cypress evelyn masso <[email protected]> Co-authored-by: Stalgia Grigg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was opening the
Manage Assistive Technology Versionsdisclosure on the Test Queue page to add/edit AT verions. Found that if I hitESCon my keyboard to close either modals, an error is thrown which readsonHide is not a functionwhere the stacktrace points to a line insidereact-bootstrap's Modal component. Screenshot:I confirmed this doesn't happen on production so my only guess is this error was introduced in #1148 when
react-bootstrapwas bumped from2.7.0to2.10.4. Although, nothing obvious jumps out at me when viewing the release notes.This PR should restore the functionality that's on production (although I'm also wondering if the title refocus instead of closing the modal is intentional).