Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: terminology update for priority 3 (MAY), passed/failing -> supported/unsupported #1150

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

stalgiag
Copy link
Contributor

@stalgiag stalgiag commented Jul 11, 2024

This PR updates language in the UI for assertion verdicts from 'passed/failed' to 'unsupported/supported' for priority 3 (MAY) assertions.

This supersedes the previous incorrect PR at #1149 . Thanks for pointing out my misreading of the task @howard-e !

This PR addresses #1145


@stalgiag stalgiag changed the title terminology update for priority 3 (MAY), passed/failing -> supported/unsupported fix: terminology update for priority 3 (MAY), passed/failing -> supported/unsupported Jul 11, 2024
@stalgiag stalgiag requested a review from howard-e July 11, 2024 17:02
Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stalgiag looks good!

@howard-e howard-e merged commit 1f61c87 into development Jul 15, 2024
2 checks passed
@howard-e howard-e deleted the terminology-update-supported-unsupported branch July 15, 2024 13:58
howard-e added a commit that referenced this pull request Jul 22, 2024
Includes the following changes:

**Features and Fixes**
* #1125 
* #1135
* #1144
* #1146
* #1150
* #1152
* #1153
* #1160

**Infrastructure changes**
* #969
* #1151
* #1148

---------

Co-authored-by: alflennik <[email protected]>
Co-authored-by: Mx Corey Frang <[email protected]>
Co-authored-by: cypress evelyn masso <[email protected]>
Co-authored-by: Stalgia Grigg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants