Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Client API to not expose reserved clients #1259

Merged
merged 1 commit into from
Jan 13, 2018
Merged

Commits on Jan 12, 2018

  1. Clean up Client API to not expose reserved clients

    To reflect the decision to not expose reserved clients
    (#1216) and to spec
    .resultingClientId and .targetClientId in Nightly only, this:
    
    * Removes
     - Client.reserved and its associated reserved state (V1, Nightly)
     - ClientQueryOptions.includeReserved (V1, Nightly)
     - FetchEvent.reservedClientId (V1)
     - FetchEvent.targetClientId (V1)
     - FetchEventInit.reservedClientId (V1)
     - FetchEventInit.targetClientId (V1)
    
    * Changes
     - FetchEvent.reservedClientId to FetchEvent.resultingClientId (Nightly)
     - FetchEventInit.reservedClientId to FetchEventInit.resultingClientId
       (Nightly)
     - Handle Fetch to set FetchEvent.clientId for a navigation request to
       the empty string (V1)
    
    * Corrects
     - matchedClients with clientObjects in Clients.matchAll() (V1, Nightly)
    
    Related issue: #1245.
    
    This also cleans up sort condition steps in Clients.matchAll() that
    fixes #1080 (V1, Nightly)
    
    (Changes for the Clients interface's methods will be addressed as
    separate PRs.)
    jungkees committed Jan 12, 2018
    Configuration menu
    Copy the full SHA
    5ab28e8 View commit details
    Browse the repository at this point in the history