Clean up Client API to not expose reserved clients #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reflect the decision to not expose reserved clients (#1216) and to spec .resultingClientId and .targetClientId in Nightly only, this: * Removes - Client.reserved and its associated reserved state (V1, Nightly) - ClientQueryOptions.includeReserved (V1, Nightly) - FetchEvent.reservedClientId (V1) - FetchEvent.targetClientId (V1) - FetchEventInit.reservedClientId (V1) - FetchEventInit.targetClientId (V1) * Changes - FetchEvent.reservedClientId to FetchEvent.resultingClientId (Nightly) - FetchEventInit.reservedClientId to FetchEventInit.resultingClientId (Nightly) - Handle Fetch to set FetchEvent.clientId for a navigation request to the empty string (V1) * Corrects - matchedClients with clientObjects in Clients.matchAll() (V1, Nightly) Related issue: #1245. This also cleans up sort condition steps in Clients.matchAll() that fixes #1080 (V1, Nightly) (Changes for the Clients interface's methods will be addressed as separate PRs.)
|
|
jakearchibald
approved these changes
Jan 12, 2018
|
LGTM. As you say, the only missing bit is making sure |
|
LGTM. |
jungkees
added a commit
to jungkees/web-platform-tests
that referenced
this pull request
Jan 13, 2018
As per the decision in w3c/ServiceWorker#1216. Related spec PR: w3c/ServiceWorker#1259.
|
Related PR for WPT: web-platform-tests/wpt#9023. |
|
LGTM too. |
jungkees
pushed a commit
that referenced
this pull request
Jun 13, 2018
To reflect the decision that we don't expose reserved clients (#1216), this change introduces the client's discarded flag, and uses that flag and the execution ready flag to resolve the promise when the client reaches one of those states instead of capturing and exposing the reserved client. Follow-up to 07e9487 (#1259).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reflect the decision to not expose reserved clients
(#1216) and to spec
.resultingClientId and .targetClientId in Nightly only, this:
Removes
Changes
(Nightly)
the empty string (V1)
Corrects
Related issue: #1245.
This also cleans up sort condition steps in Clients.matchAll() that
fixes #1080 (V1, Nightly)
(Changes for the Clients interface's methods will be addressed as
separate PRs.)
Preview | Diff