Skip to content

T8782: remove redundant pr-auto-close.yml on circinus - #5229

Merged
andamasov merged 1 commit into
circinusfrom
feature/remove-pr-auto-close-circinus
May 28, 2026
Merged

andamasov merged 1 commit into
circinusfrom
feature/remove-pr-auto-close-circinus

Conversation

@andamasov

Copy link
Copy Markdown
Member

Summary

Removes .github/workflows/pr-auto-close.yml from the circinus branch. Functionality is replaced by the central Mergify rule vyos/mergify#13 (merged), which closes PRs targeting EOL release branches (sagitta, crux, circinus) across every vyos/* repo that extends the central baseline.

Why this is safe

  • vyos/vyos-1x extends the central Mergify config via .github/mergify.yml on the current (default) branch.
  • Per Mergify docs, Mergify reads its configuration from the default branch regardless of the PR's target branch.
  • The central rule already fires on any PR opened against circinus in this repo.

Sibling cleanup of vyos/vyos-1x#5228 (sagitta, merged).

Test plan

  • After merge, open a test PR against vyos/vyos-1x:circinus and confirm Mergify closes it with the expected message.

🤖 Generated by robots

Functionality moved to the central Mergify config at vyos/mergify
(see PR vyos/mergify#13, merged), which closes PRs targeting EOL
release branches (sagitta, crux, circinus) across every vyos/* repo
that extends the central baseline.

vyos/vyos-1x extends the central config via .github/mergify.yml on
the default branch (current). Mergify reads its configuration from
the default branch regardless of the PR's target branch, so the
central rule fires on PRs targeting circinus in this repo.

Sibling cleanup of #5228 (sagitta).
@coderabbitai

coderabbitai Bot commented May 28, 2026 •

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: ea56c7f0-bcca-4999-b504-72c40b189b16

📥 Commits

Reviewing files that changed from the base of the PR and between d532241 and 2d5e6aa.

📒 Files selected for processing (1)
  • .github/workflows/pr-auto-close.yml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Removed an automated workflow configuration that was handling pull requests.

Walkthrough

The pull request removes the entire .github/workflows/pr-auto-close.yml workflow file (22 lines deleted). This workflow previously triggered on pull_request_target events for the circinus branch and automatically closed matching pull requests using a third-party close action with a personal access token.

Changes

Cohort / File(s) Summary
Workflow removal
.github/workflows/pr-auto-close.yml
Complete deletion of the PR auto-close workflow that targeted circinus branch pull requests.

Possibly related PRs

  • vyos/vyos-1x#5221: Adds or modifies the same pr-auto-close.yml workflow—inverse relationship to this removal.
  • vyos/vyos-1x#5223: Also modifies .github/workflows/pr-auto-close.yml, specifically its workflow name.
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch feature/remove-pr-auto-close-circinus

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

Pull requests to this branch are not accepted and have been closed automatically.

@github-actions github-actions Bot closed this May 28, 2026
@github-actions

Copy link
Copy Markdown

👍
No issues in PR Title / Commit Title

@andamasov andamasov reopened this May 28, 2026
@andamasov
andamasov marked this pull request as ready for review May 28, 2026 10:28
@andamasov
andamasov requested a review from a team as a code owner May 28, 2026 10:28
@andamasov
andamasov requested review from alexandr-san4ez, c-po, dmbaturin, hedrok, jestabro, sarthurdev and zdc and removed request for a team May 28, 2026 10:28
@andamasov
andamasov merged commit b9b966a into circinus May 28, 2026
12 of 14 checks passed
@andamasov
andamasov deleted the feature/remove-pr-auto-close-circinus branch May 28, 2026 10:28
@mergify

mergify Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Pull requests targeting EOL release branches (sagitta, crux, circinus) are not accepted and have been closed automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant