Repository navigation
T8782: remove redundant pr-auto-close.yml on sagitta - #5228
Merged
Merged
Conversation
Functionality moved to the central Mergify config at vyos/mergify (see PR vyos/mergify#13), which closes PRs targeting EOL release branches (sagitta, crux, circinus) across every vyos/* repo that extends the central baseline. vyos/vyos-1x extends the central config via .github/mergify.yml on the default branch (current). Mergify reads its configuration from the default branch regardless of the PR's target branch, so the new central rule will fire on PRs targeting sagitta in this repo once vyos/mergify#13 lands. This deletion is gated on vyos/mergify#13 via the Depends-On marker in the PR body so Mergify holds the merge until upstream lands and no coverage gap opens. Two related cleanups remain (separate PRs): - .github/workflows/pr-auto-close.yml on the circinus branch - .github/workflows/pr-auto-close.yml on the current branch (dormant — its branch filter targets sagitta/circinus only, but pull_request_target evaluates the file from the target branch, so it never fires).
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR removes Changes
Possibly related PRs
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Pull requests to this branch are not accepted and have been closed automatically. |
|
👍 |
andamasov
marked this pull request as ready for review
May 28, 2026 10:22
andamasov
requested review from
dmbaturin,
hedrok,
jestabro,
natali-rs1985,
sarthurdev,
sever-sever and
zdc
and removed request for
a team
May 28, 2026 10:22
|
Pull requests to this branch are not accepted and have been closed automatically. |
This was referenced May 28, 2026
natali-rs1985
pushed a commit
to natali-rs1985/vyos-1x
that referenced
this pull request
May 28, 2026
This workflow was a newer copy of the per-branch pr-auto-close.yml files, with a branch filter targeting both sagitta and circinus. It never actually fired: pull_request_target evaluates the workflow from the PR's TARGET branch, not the default branch. PRs targeting sagitta used .github/workflows/pr-auto-close.yml from the sagitta branch; PRs targeting circinus used circinus's copy. The file on current matched no events. Functionality is now centralized in the Mergify config at vyos/mergify (see PR vyos/mergify#13, merged). vyos/vyos-1x extends that baseline via .github/mergify.yml on this branch. Sibling cleanup of vyos#5228 (sagitta) and the parallel PR removing circinus's copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
.github/workflows/pr-auto-close.ymlfrom thesagittabranch. Functionality is replaced by the central Mergify rule shipped in vyos/mergify#13, which closes PRs targeting EOL release branches (sagitta,crux,circinus) across everyvyos/*repo that extends the central baseline.Why this is safe
vyos/vyos-1xextends the central Mergify config via.github/mergify.ymlon thecurrent(default) branch.Auto-close PRs targeting EOL release branchesrule will fire on any PR opened againstsagittain this repo.Sequencing
Depends-On: vyos/mergify#13The Mergify built-in Depends-On merge protection will hold this PR's merge until vyos/mergify#13 lands, ensuring no coverage gap between the GHA being deleted and the Mergify rule taking over.
Related cleanups (separate follow-up PRs)
Two more copies of the same workflow exist on other branches; left out of this PR to keep the diff scoped:
circinus.github/workflows/pr-auto-close.ymlcurrent.github/workflows/pr-auto-close.ymlpull_request_targetevaluates the workflow from the PR's target branch, so a file oncurrentnever fires for PRs to sagitta/circinus. Safe to delete.Test plan
vyos/vyos-1x:sagittaand confirm Mergify closes it with the expected message.🤖 Generated by robots