Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sfc): avoid to deindent when pad option is specified #7647

Merged
merged 2 commits into from
Oct 24, 2018

Conversation

ktsn
Copy link
Member

@ktsn ktsn commented Feb 14, 2018

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
I'm developing some editor extension which can highlight styles and noticed if there are root indentation, the highlight position is broken. I've found this is because vue-template-compiler deindents SFC contents even when pad option is specified.

I've changed this behavior to only deindent when pad option is not specified.

I have no idea why the template option is not padded but it would be needed to provide correct position of template block? If I'm missing something, please let me know.

@yyx990803 yyx990803 merged commit 9d2f9a0 into vuejs:dev Oct 24, 2018
@ktsn ktsn deleted the avoid-deindent branch October 24, 2018 16:55
yyx990803 added a commit that referenced this pull request Dec 9, 2018
@yyx990803
Copy link
Member

@ktsn I've reverted this change due to this breaking some existing pug usage (#9169), but we will merge #7215 in 2.6 so that you can specify deindent: false to explicitly control this behavior.

@ktsn
Copy link
Member Author

ktsn commented Dec 10, 2018

@yyx990803 I see. Thank you for letting me know!

f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants