Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pug templates no longer compile with an initial indent #9169

Closed
KaelWD opened this issue Dec 9, 2018 · 6 comments
Closed

Pug templates no longer compile with an initial indent #9169

KaelWD opened this issue Dec 9, 2018 · 6 comments

Comments

@KaelWD
Copy link
Contributor

KaelWD commented Dec 9, 2018

Version

2.5.18

Reproduction link

https://github.com/KaelWD/vue-2.5.18-pug-compiler

Steps to reproduce

  • Clone repo
  • yarn
  • yarn build

What is expected?

Project should compile

What is actually happening?

Error: src/App.vue:2:1
    1| 
  > 2|   #app
-------^
    3|     div Hello World!
    4| 

unexpected token "indent"

Works if you downgrade to 2.5.17 or remove the initial indent in the template

@KaelWD
Copy link
Contributor Author

KaelWD commented Dec 9, 2018

I didn't even bother to check for closed duplicates, turns out @Justineo already rejected #9163. This is definitely a valid issue, it's worked fine for a very long time and there are commits by other vue members specifically for this use case: vuejs/rollup-plugin-vue#90

@yyx990803
Copy link
Member

Seems weird for this to be caused by vue-template-compiler. If anyone can bisect this to a specific commit that would be great.

@KaelWD
Copy link
Contributor Author

KaelWD commented Dec 9, 2018

🤔 fe194dd

Maybe I did it wrong lol

@Justineo
Copy link
Member

Justineo commented Dec 9, 2018

I think it is this one: 9d2f9a0#diff-ea1dca0013e7b19f0d16e22b9951879a

@KaelWD
Copy link
Contributor Author

KaelWD commented Dec 9, 2018

Yeah that makes more sense haha, seems like yarn link doesn't play too nice with vue.

@yyx990803
Copy link
Member

closed by reverting #7647 in 5d721a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants