Add support for metalsmith builder hooks #428
Conversation
|
I think this would be even better with tests. |
|
I'll write one test that writes target files to another destination, as I think it would be a common use case. |
|
Test written. I have also removed |
| expect(getTemplatePath('../template')).to.equal(path.join(__dirname, '/../../../template')) | ||
| }) | ||
|
|
||
| it.only('points out the file in the error', done => { |
zigomir
left a comment
zigomir
left a comment
There was a problem hiding this comment.
Looking good. Still it would be even better if test code exercises more paths like for before and after.
| delete files['readme.md'] | ||
| files['custom/readme.md'] = readme | ||
|
|
||
| console.log(files) |
There was a problem hiding this comment.
I believe this could be removed.
|
|
||
| var readme = files['readme.md'] | ||
| delete files['readme.md'] | ||
| files['custom/readme.md'] = readme |
There was a problem hiding this comment.
Just to be sure. What you're doing here in custom metalsmith plugin is you're moving file from root template directory into custom directory, right?
| @@ -0,0 +1,17 @@ | |||
| module.exports = { | |||
| "metalsmith": function (metalsmith, opts, helpers) { | |||
There was a problem hiding this comment.
Besides this one you can also test before and after, right?
There was a problem hiding this comment.
I just push a new commit with an additional test, and better assertions
Toilal
force-pushed
the
feature/metalsmith-builder-hooks
branch
from
0a8c6a7 to
0125ac7
Compare
|
@Toilal looks good, thank you! |
4 participants
Close #427