Skip to content

test: add valid example for empty defineEmits#2914

Closed
Sysix wants to merge 1 commit intovuejs:masterfrom
Sysix:test-empty-defineemits-with-export-default
Closed

test: add valid example for empty defineEmits#2914
Sysix wants to merge 1 commit intovuejs:masterfrom
Sysix:test-empty-defineemits-with-export-default

Conversation

@Sysix
Copy link
Copy Markdown
Contributor

@Sysix Sysix commented Aug 3, 2025

Covering this part of the code:

if (emptyDefineEmits) {
if (!hasDefaultExport) {
// Custom events are not defined.
context.report({
node: emptyDefineEmits,
messageId: 'notDefined'
})
}

Found in oxc-project/oxc#12545

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 3, 2025

⚠️ No Changeset found

Latest commit: ce26e0d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ota-meshi
Copy link
Copy Markdown
Member

I don't understand, could you please explain in more detail?

@Sysix
Copy link
Copy Markdown
Contributor Author

Sysix commented Aug 3, 2025

I don't understand, could you please explain in more detail?

It just extends the test suite with this special use case. (See linked code part).
Do be fair, I do not know if this is valid in the real world. But the rule allows it.

I am currently working on the implementation of the rule in oxlint.
This test should help to be consistent across different tools.
oxlint will generate their test code from test source code of the plugin.

If you think, this is not helpful as a test case, feel free to close.
I wanted to be sure we do not include inconsistency between both tools.

@ota-meshi
Copy link
Copy Markdown
Member

If you think, this is not helpful as a test case, feel free to close.

I'll close it.

@ota-meshi ota-meshi closed this Aug 4, 2025
graphite-app Bot pushed a commit to oxc-project/oxc that referenced this pull request Aug 27, 2025
related #11440

https://github.com/vuejs/eslint-plugin-vue/blob/master/docs/rules/valid-define-emits.md

Extended the docs and tests to cover (non) empty `defineEmits()` with `export default` of other script block.
Related vuejs/eslint-plugin-vue#2914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants