Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-core): allow unicode to appear in simple identifiers #6765

Merged
merged 5 commits into from
May 30, 2024

Conversation

godxiaoji
Copy link
Contributor

fix #6367

I refer to #3443 .

@skirtles-code
Copy link
Contributor

I commented on this previously, but that comment has been incorrectly marked as resolved.

I believe this PR still needs a test adding. The test that has been included doesn't seem to be related to the change.

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.8 kB 34.5 kB 31.1 kB
vue.global.prod.js 148 kB (+11 B) 53.7 kB (+1 B) 48 kB (+19 B)

Usages

Name Size Gzip Brotli
createApp 50.8 kB 19.9 kB 18.1 kB
createSSRApp 54.1 kB 21.2 kB 19.3 kB
defineCustomElement 53.1 kB 20.6 kB 18.8 kB
overall 64.6 kB 24.9 kB 22.6 kB

@godxiaoji
Copy link
Contributor Author

I commented on this previously, but that comment has been incorrectly marked as resolved.

I believe this PR still needs a test adding. The test that has been included doesn't seem to be related to the change.

I have submitted a new test, please review it again.

@godxiaoji godxiaoji requested a review from edison1105 May 30, 2024 05:37
@edison1105 edison1105 added the ready to merge The PR is ready to be merged. label May 30, 2024
@yyx990803 yyx990803 merged commit 3ea9644 into vuejs:main May 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready for review This PR requires more reviews ready to merge The PR is ready to be merged.
Projects
Development

Successfully merging this pull request may close these issues.

When using Non Ascii alias for list items in v-for directive, event handling is not working as expected.
5 participants