fix(compiler-core): simple identifier should include Chinese #10575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
baiwusanyu-c
suggested changes
Mar 23, 2024
| @@ -62,7 +62,7 @@ export function isCoreComponent(tag: string): symbol | void { | |||
| } | |||
| } | |||
|
|
|||
| const nonIdentifierRE = /^\d|[^\$\w]/ | |||
| const nonIdentifierRE = /^\d|[^\$\w\u4e00-\u9fa5]/ | |||
|
duplicate of #6765 |
sxzz
reviewed
Mar 24, 2024
Comment on lines
+65
to
67
| const nonIdentifierRE = /^\d|[^\$\w\u4e00-\u9fa5]/ | ||
| export const isSimpleIdentifier = (name: string): boolean => | ||
| !nonIdentifierRE.test(name) |
There was a problem hiding this comment.
I think we can refactor this part by using propNameEscapeSymbolsRE (move it to shared pkg)
There was a problem hiding this comment.
seems that directly use this regx to instead will break other test units
|
#6765 has now been merged. The fix and test in that PR are slightly different from those found here. I'm unclear whether this PR is still worth pursuing, but it will need the conflicts resolving if it is. |
|
Close as duplicate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #10542